Chromium Code Reviews Chromium Code Reviews
Issue 12693022:
Added separate tabs for apps / extensions in dev_tools app. (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| Index: chrome/browser/resources/apps_debugger/main.html |
| diff --git a/chrome/browser/resources/apps_debugger/main.html b/chrome/browser/resources/apps_debugger/main.html |
| index 85a9e86e8118efa5e1be5c6f24c3c90563514df5..3f9a99f9d34a10592a94d648706dc0347f306eba 100644 |
| --- a/chrome/browser/resources/apps_debugger/main.html |
| +++ b/chrome/browser/resources/apps_debugger/main.html |
| @@ -5,7 +5,7 @@ |
| Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| Use of this source code is governed by a BSD-style license that can be |
| found in the LICENSE file. |
| - |
| +ii |
|
Dan Beam
2013/03/20 19:05:30
^ remove
Gaurav
2013/03/29 21:14:26
Done.
|
| --> |
| <head> |
| <meta charset="utf-8"> |
| @@ -14,6 +14,7 @@ found in the LICENSE file. |
| <link rel="stylesheet" href="css/pack_item_overlay.css"> |
| <link rel="stylesheet" href="css/permissions_overlay.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/alert_overlay.css"> |
| + <link rel="stylesheet" href="../../../../ui/webui/resources/css/tabs.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/overlay.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/trash.css"> |
| <link rel="stylesheet" href="../uber/uber_shared.css"> |
| @@ -26,27 +27,46 @@ found in the LICENSE file. |
| <include src="permissions_overlay.html"> |
| <include src="../../../../ui/webui/resources/html/alert_overlay.html"> |
| </div> |
| - <hr> |
| <div class="page" id="extension-settings"> |
| + <hr> |
| <h1 i18n-content="appsDevtoolTitle"></h1> |
| - <div id="developer-controls"> |
| - <hr> |
| - <button id="load-unpacked" |
| - i18n-content="appsDevtoolLoadUnpackedButton"></button> |
| - <button id="pack-item" |
| - i18n-content="appsDevtoolPackButton"></button> |
| - <button id = "update-items-now" |
| - i18n-content="appsDevtoolUpdateButton"></button> |
| - <input id="search" type="text" placeholder="type to search" |
| - spellcheck="false"> |
| - <hr> |
| - </div> |
| - <div id="items"></div> |
| - <div id="extension-settings-list" class="empty-extension-list"></div> |
| - <div id="no-extensions"> |
| - <span id="no-extensions-message" |
| - i18n-content="appsDevtoolNoItems"></span> |
| - </div> |
| + <tabbox id="tabbox"> |
|
Dan Beam
2013/03/20 19:05:30
^ is this the standard tab element naming?
Gaurav
2013/03/29 21:14:26
Not sure, it is used in some code. Changing it to
|
| + <tabs id="tabs"> |
| + <tab> Apps</tab> |
| + <tab> Extensions </tab> |
|
Dan Beam
2013/03/20 19:05:30
remove spaces, where's translations?
Gaurav
2013/03/29 21:14:26
Done.
|
| + </tabs> |
| + <div id="developer-controls"> |
| + <button id="load-unpacked" |
| + i18n-content="appsDevtoolLoadUnpackedButton"></button> |
| + <button id="pack-item" |
| + i18n-content="appsDevtoolPackButton"></button> |
| + <button id = "update-items-now" |
| + i18n-content="appsDevtoolUpdateButton"></button> |
| + <input id="search" type="text" placeholder="type to search" |
|
Dan Beam
2013/03/20 19:05:30
translations? this will conflict with your other p
Gaurav
2013/03/29 21:14:26
Done.
|
| + spellcheck="false"> |
| + <hr> |
| + </div> |
| + <tabpanels id="tabpanels"> |
| + <!-- Apps Tab --> |
| + <tabpanel id="apps-tab"> |
| + <div id="app-settings-list" class="empty-extension-list"> |
| + </div> |
| + <div id="no-apps"> |
| + <span id="no-apps-message" |
| + i18n-content="appsDevtoolNoApps"></span> |
| + </div> |
| + </tabpanel> |
| + <!-- Extensions Tab --> |
| + <tabpanel id="extensions-tab"> |
| + <div id="extension-settings-list" class="empty-extension-list"> |
| + </div> |
| + <div id="no-extensions"> |
| + <span id="no-extensions-message" |
| + i18n-content="appsDevtoolNoExtensions"></span> |
| + </div> |
| + </tabpanel> |
| + </tabpanels> |
| + </tabbox> |
| </div> |
| <div id="template-collection" hidden> |
| <div class="extension-list-item-wrapper"> |
