Added separate tabs for apps / extensions in dev_tools app.

chrome/browser/resources/apps_debugger/js/items_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('apps_dev_tool', function() {
   'use strict';
 
   /**
    * Creates a new list of items.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
    */
   var ItemsList = cr.ui.define('div');
 
   // The list of all apps & extensions.
   var completeList = [];
 
   // The list of all apps.
   var appList = [];
 
+  // The list of all extensions.
+  var extensionList = [];
+
   /** const*/ var AppsDevTool = apps_dev_tool.AppsDevTool;
 
   /**
    * @param {string} a first string.
    * @param {string} b second string.
    * @return {number} 1, 0, -1 if |a| is lexicographically greater, equal or
    *     lesser than |b| respectively.
    */
   function compare(a, b) {
     return a > b ? 1 : (a == b ? 0 : -1);
@@ skipping 18 matching lines @@
    * @param {string} app2 second app_name.
    */
   function compareByName(app1, app2) {
     return compare(app1.name.toLowerCase(), app2.name.toLowerCase());
   }
 
   /**
    * Refreshes the app.
    */
   function reloadAppDisplay() {
-    var itemsDiv = $('items');
+    ItemsList.prototype.data_ = extensionList;

[Dan Beam, 2013/03/20 19:05:30]

^ I'm confused as to what this is doing?

[Gaurav, 2013/03/29 21:14:26]

It initializes the data in ItemsList fow which the items are created in
createNode_()

[Dan Beam, 2013/03/29 21:48:13]

This should be setting this on an instance, not on the prototype (which affects
all future instances), AFAIK.

 
-    // Empty the current content.
-    itemsDiv.textContent = '';
+    var extensions = $('extension-settings-list');
+    ItemsList.decorate(extensions);
 
     ItemsList.prototype.data_ = appList;
-    var itemsList = $('extension-settings-list');
-    ItemsList.decorate(itemsList);
+    var apps = $('app-settings-list');
+    ItemsList.decorate(apps);
   }
 
   /**
    * Applies the given |filter| to the items list.
    * @param {string} filter Curent string in the search box.
    */
   function rebuildAppList(filter) {
-    if (!filter) {
-      appList = completeList;
-      return;
-    }
+    appList = [];
+    extensionList = [];
 
-    appList = [];
     for (var i = 0; i < completeList.length; i++) {
       var item = completeList[i];
       if (item.name.toLowerCase().search(filter) < 0)

[Dan Beam, 2013/03/20 19:05:30]

nit: if (filter && item.name.toLowerCase().search(filter) < 0)

[Gaurav, 2013/03/29 21:14:26]

Done.

         continue;
-
-      appList.push(item);
+      if (item.isApp)
+        appList.push(item);
+      else
+        extensionList.push(item);
     }
   }
 
   ItemsList.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /**
      * |data_| holds the metadata of all the apps and extensions.
      * @type {!Array.<!Object>}
      * @private
      */
     data_: [],
 
     /**
      * @override
      */
     decorate: function() {
       this.textContent = '';
       this.showItemNodes_();
     },
 
     /**
      * Creates all items from scratch.
      * @private
      */
     showItemNodes_: function() {
       // Iterate over the item data and add each item to the list.
-      this.classList.toggle('empty-extension-list', this.data_.length == 0);
+      this.classList.toggle('empty-item-list', this.data_.length == 0);
       this.data_.forEach(this.createNode_, this);
     },
 
     /**
      * Synthesizes and initializes an HTML element for the item metadata
      * given in |item|.
      * @param {!Object} item A dictionary of item metadata.
      * @private
      */
     createNode_: function(item) {
@@ skipping 313 matching lines @@
     chrome.management.launchApp(id, function() {
       // There is a delay in generation of background page for the app.
       setTimeout(ItemsList.loadItemsInfo, 1000);
     });
   };
 
   return {
     ItemsList: ItemsList,
   };
 });