Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/resources/apps_debugger/js/items.js

Issue 12693022: Added separate tabs for apps / extensions in dev_tools app. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('apps_dev_tool', function() { 5 cr.define('apps_dev_tool', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * AppsDevTool constructor. 9 * AppsDevTool constructor.
10 * @constructor 10 * @constructor
11 * @extends {HTMLDivElement} 11 * @extends {HTMLDivElement}
12 */ 12 */
13 function AppsDevTool() {} 13 function AppsDevTool() {}
14 14
15 AppsDevTool.prototype = { 15 AppsDevTool.prototype = {
16 __proto__: HTMLDivElement.prototype, 16 __proto__: HTMLDivElement.prototype,
17 17
18 /** 18 /**
19 * Perform initial setup. 19 * Perform initial setup.
20 */ 20 */
21 initialize: function() { 21 initialize: function() {
22
Dan Beam 2013/03/20 19:05:30 nit: no \n
Gaurav 2013/03/29 21:14:26 Done.
23 // Initialize the tabs.
Dan Beam 2013/03/20 19:05:30 ^ considering this is right below `initialize`, th
Gaurav 2013/03/29 21:14:26 Done.
24 cr.ui.decorate('tabbox', cr.ui.TabBox);
Dan Beam 2013/03/20 19:05:30 nit: tab-box, IMO
Gaurav 2013/03/29 21:14:26 This only seem to work with "tabbox".
25
22 // Set up the three buttons (load unpacked, pack and update). 26 // Set up the three buttons (load unpacked, pack and update).
23 $('load-unpacked').addEventListener('click', 27 $('load-unpacked').addEventListener('click',
24 this.handleLoadUnpackedItem_.bind(this)); 28 this.handleLoadUnpackedItem_.bind(this));
25 $('pack-item').addEventListener('click', 29 $('pack-item').addEventListener('click',
26 this.handlePackItem_.bind(this)); 30 this.handlePackItem_.bind(this));
27 $('update-items-now').addEventListener('click', 31 $('update-items-now').addEventListener('click',
28 this.handleUpdateItemNow_.bind(this)); 32 this.handleUpdateItemNow_.bind(this));
29 $('permissions-close').addEventListener('click', function() { 33 $('permissions-close').addEventListener('click', function() {
30 AppsDevTool.showOverlay(null); 34 AppsDevTool.showOverlay(null);
31 }); 35 });
Dan Beam 2013/04/03 22:56:24 ^ why was this deleted?
Gaurav 2013/04/04 17:50:58 Instead of writing a permissions overlay ui, I reu
32 var packItemOverlay = 36 var packItemOverlay =
33 apps_dev_tool.PackItemOverlay.getInstance().initializePage(); 37 apps_dev_tool.PackItemOverlay.getInstance().initializePage();
34 }, 38 },
35 39
36 /** 40 /**
37 * Handles the Load Unpacked Extension button. 41 * Handles the Load Unpacked Extension button.
38 * @param {!Event} e Click event. 42 * @param {!Event} e Click event.
39 * @private 43 * @private
40 */ 44 */
41 handleLoadUnpackedItem_: function(e) { 45 handleLoadUnpackedItem_: function(e) {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 chrome.developerPrivate.getStrings(function(strings) { 97 chrome.developerPrivate.getStrings(function(strings) {
94 loadTimeData.data = strings; 98 loadTimeData.data = strings;
95 i18nTemplate.process(document, loadTimeData); 99 i18nTemplate.process(document, loadTimeData);
96 }); 100 });
97 }; 101 };
98 102
99 return { 103 return {
100 AppsDevTool: AppsDevTool, 104 AppsDevTool: AppsDevTool,
101 }; 105 };
102 }); 106 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698