Issue 12693016: Reimplement HWNDMessageHandler WM_SETCURSOR handling to avoid artifacts, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12693016: Reimplement HWNDMessageHandler WM_SETCURSOR handling to avoid artifacts, etc. (Closed)

Created:
7 years, 9 months ago by msw

Modified:
7 years, 9 months ago

Reviewers:
sky, Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reimplement HWNDMessageHandler WM_SETCURSOR handling to avoid artifacts, etc. Reimplement the necessary default WM_SETCURSOR handling. Calling DefWindowProc can trigger weird non-client painting. ScopedRedrawLock may allow content behind the window to show through. Invalidating to hide artifacts is inefficient and incomplete. NOTE: I only covered the hit-test cases I've observed in use. BUG=89820, 97808, 113127, 178600, 181282, 195768 TEST=Windows cursors appear as expected; no missing cases. R=sky@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188817

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
	M	ui/views/win/hwnd_message_handler.cc	View		1 chunk	+31 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12693016/1

7 years, 9 months ago (2013-03-18 17:39:58 UTC) #3

Message was sent while issue was closed.

Change committed as 188817

Expand Messages | Collapse Messages