Issue 12686006: Rename GoogleServiceAuthError::None() to AuthErrorNone() and LoginFailure::None() to LoginFailureNo…

Issue 12686006: Rename GoogleServiceAuthError::None() to AuthErrorNone() and LoginFailure::None() to LoginFailureNo… (Closed)

Created:
7 years, 9 months ago by Denis Kuznetsov (DE-MUC)

Modified:
7 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, nkostylev+watch_chromium.org, Raghu Simha, tim (not reviewing), oshima+watch_chromium.org, haitaol1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, akalin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename GoogleServiceAuthError::None() to AuthErrorNone() and LoginFailure::None() to LoginFailureNone() so that they do not clash with None defined in /usr/include/X11/X.h. TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187652

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -40 lines)			Patch
M	chrome/browser/chromeos/login/login_performer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_performer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_status_consumer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/online_attempt.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/online_attempt_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/parallel_authenticator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/parallel_authenticator_unittest.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/policy/user_info_fetcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/fake_auth_status_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/oauth2_token_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/oauth2_token_service_request_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/oauth2_token_service_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/signin_global_error.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/signin_global_error_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/ubertoken_fetcher_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	google_apis/gaia/google_service_auth_error.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google_apis/gaia/google_service_auth_error.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google_apis/gaia/google_service_auth_error_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download