Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 12686003: Reduce the number of locales for iOS. (Closed)

Created:
7 years, 9 months ago by jeanfrancoisg
Modified:
7 years, 9 months ago
Reviewers:
Mark Mentovai, tony
CC:
chromium-reviews, Mark Mentovai, bradnelson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reduce the number of locales for iOS. iOS only supports a limited amount of languages ( https://sites.google.com/a/google.com/mobile-effort/ios/i18n-and-l10n ). We must remove the unused languages to reduce the app's size. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188336

Patch Set 1 #

Patch Set 2 : 80 char #

Patch Set 3 : Comment. #

Total comments: 1

Patch Set 4 : Override locales in ios block. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/common.gypi View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jeanfrancoisg
7 years, 9 months ago (2013-03-11 09:21:27 UTC) #1
tony
https://codereview.chromium.org/12686003/diff/3001/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/12686003/diff/3001/build/common.gypi#oldcode938 build/common.gypi:938: # NOTE: When these end up in the Mac ...
7 years, 9 months ago (2013-03-11 17:55:14 UTC) #2
jeanfrancoisg
You are right. I can't seem to make it work though. The iOS locales list ...
7 years, 9 months ago (2013-03-13 13:22:01 UTC) #3
tony
Hmm, I can't seem to get it to work. I guess your original patch LGTM. ...
7 years, 9 months ago (2013-03-13 20:55:51 UTC) #4
Mark Mentovai
Depending on where the two 'locales' keys are relative to each other, there may be ...
7 years, 9 months ago (2013-03-13 21:05:36 UTC) #5
tony
On 2013/03/13 21:05:36, Mark Mentovai wrote: > Depending on where the two 'locales' keys are ...
7 years, 9 months ago (2013-03-13 21:14:23 UTC) #6
jeanfrancoisg
Thanks a lot! I ended up with 'locales' for the main list and 'locales==' in ...
7 years, 9 months ago (2013-03-14 10:12:09 UTC) #7
tony
LGTM, thanks!
7 years, 9 months ago (2013-03-14 17:00:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeanfrancoisg@google.com/12686003/13001
7 years, 9 months ago (2013-03-14 17:31:12 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 11:15:45 UTC) #10
Message was sent while issue was closed.
Change committed as 188336

Powered by Google App Engine
This is Rietveld 408576698