Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12685010: Added gsutil/gslib to depot_tools/third_party (Closed)

Created:
7 years, 9 months ago by Ryan Tseng
Modified:
7 years, 9 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, Isaac (away)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Added gsutil/gslib to depot_tools/third_party This is needed for https://chromiumcodereview.appspot.com/12042069/ Which uses gsutil to download objects from Google Storage based on SHA1 sums Continuation of: https://chromiumcodereview.appspot.com/12317103/ Rietveld didn't like a giant CL with all of gsutil (kept crashing on upload), The CL is being split into three parts Related: https://chromiumcodereview.appspot.com/12755026 (gsutil/boto) https://codereview.chromium.org/12685009/ (gsutil/) BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188842

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12534 lines, -0 lines) Patch
A third_party/gsutil/gslib/README View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/__init__.py View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/__init__.py View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/acls.py View 1 chunk +234 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/anon.py View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/command_opts.py View 1 chunk +116 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/dev.py View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/metadata.py View 1 chunk +186 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/naming.py View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/prod.py View 1 chunk +160 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/projects.py View 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/subdirs.py View 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/support.py View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/versioning.py View 1 chunk +242 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/addlhelp/wildcards.py View 1 chunk +170 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/bucket_listing_ref.py View 1 chunk +175 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/command.py View 1 chunk +722 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/command_runner.py View 1 chunk +101 lines, -0 lines 2 comments Download
A third_party/gsutil/gslib/commands/__init__.py View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/cat.py View 1 chunk +131 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/chacl.py View 1 chunk +523 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/config.py View 1 chunk +694 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/cp.py View 1 chunk +1819 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/disablelogging.py View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/enablelogging.py View 1 chunk +149 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getacl.py View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getcors.py View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getdefacl.py View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getlogging.py View 1 chunk +137 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getversioning.py View 1 chunk +116 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/getwebcfg.py View 1 chunk +122 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/help.py View 1 chunk +218 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/ls.py View 1 chunk +578 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/mb.py View 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/mv.py View 1 chunk +159 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/perfdiag.py View 1 chunk +903 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/rb.py View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/rm.py View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setacl.py View 1 chunk +138 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setcors.py View 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setdefacl.py View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setmeta.py View 1 chunk +420 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setversioning.py View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/setwebcfg.py View 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/update.py View 1 chunk +305 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/commands/version.py View 1 chunk +150 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/exception.py View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/help_provider.py View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/name_expansion.py View 1 chunk +550 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/no_op_auth_plugin.py View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/plurality_checkable_iterator.py View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/project_id.py View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/storage_uri_builder.py View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/thread_pool.py View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/util.py View 1 chunk +155 lines, -0 lines 0 comments Download
A third_party/gsutil/gslib/wildcard_iterator.py View 1 chunk +498 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Tseng
Created a new CL because the CQ freaks out if the base url isn't the ...
7 years, 9 months ago (2013-03-12 22:55:47 UTC) #1
Ryan Tseng
Gslib is actually not independent and is very tightly integrated with gsutil. There are pointers ...
7 years, 9 months ago (2013-03-15 01:52:52 UTC) #2
M-A Ruel
lgtm https://chromiumcodereview.appspot.com/12685010/diff/1/third_party/gsutil/gslib/command_runner.py File third_party/gsutil/gslib/command_runner.py (right): https://chromiumcodereview.appspot.com/12685010/diff/1/third_party/gsutil/gslib/command_runner.py#newcode52 third_party/gsutil/gslib/command_runner.py:52: commands_dir = os.path.join(self.gsutil_bin_dir, 'gslib', 'commands') On 2013/03/15 01:52:53, ...
7 years, 9 months ago (2013-03-18 18:28:40 UTC) #3
Ryan Tseng
7 years, 9 months ago (2013-03-18 22:05:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r188842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698