Issue 12684006: Correct title bar size for HiDPI Windows

Issue 12684006: Correct title bar size for HiDPI Windows (Closed)

Created:
7 years, 9 months ago by girard

Modified:
7 years, 9 months ago

Reviewers:
Ben Goodger (Google), kevers

CC:
chromium-reviews, tfarina, kevers, sky

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Correct title bar size for HiDPI Windows GetSystemMetrics was reporting title bar height in pixels, but we were interpreting them as DIP. This resulted in a double-scaled title bar. BUG=149881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188432

Patch Set 1 #

Total comments: 2

Patch Set 2 : Corrected missing #include #

Patch Set 3 : Updated comments. #

Patch Set 4 : Corrected include ordering #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/glass_browser_frame_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/base/win/dpi.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/win/dpi.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kevers

https://codereview.chromium.org/12684006/diff/1/ui/base/win/dpi.h File ui/base/win/dpi.h (right): https://codereview.chromium.org/12684006/diff/1/ui/base/win/dpi.h#newcode41 ui/base/win/dpi.h:41: // Win32's GetSystemMetrics uses pixel measures. This function converts ...

7 years, 9 months ago (2013-03-14 19:47:12 UTC) #2

girard

Updated comments. https://codereview.chromium.org/12684006/diff/1/ui/base/win/dpi.h File ui/base/win/dpi.h (right): https://codereview.chromium.org/12684006/diff/1/ui/base/win/dpi.h#newcode41 ui/base/win/dpi.h:41: // Win32's GetSystemMetrics uses pixel measures. This ...

7 years, 9 months ago (2013-03-14 20:09:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/12684006/14001

7 years, 9 months ago (2013-03-15 12:32:44 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 9 months ago (2013-03-15 13:12:51 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/12684006/14001

7 years, 9 months ago (2013-03-15 15:58:09 UTC) #8

Message was sent while issue was closed.

Change committed as 188432

Expand Messages | Collapse Messages