libgtk2ui: cast gdk_color components to fix compilation under gcc 4.7.2

libgtk2ui: cast gdk_color components to fix compilation under gcc 4.7.2

I was getting this error before this patch:

    error: narrowing conversion of ‘(((color >> 16) & 255u) * 257u)’ from ‘SkColor {aka unsigned int}’ to ‘guint16 {aka short unsigned int}’ inside { } is ill-formed in C++11 [-Werror=narrowing]

BUG=130810
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188351

[Bobby Powers, 2013-03-14 16:06:11]

I'm starting to play with Aura on my F18 box, and needed this build fix. 
Hopefully more patches to come.  Please let me know if I'm doing anything silly,
or if I've missed some bit of documentation/etiquette.

yours,
Bobby

[Elliot Glaysher, 2013-03-14 16:52:49]

https://codereview.chromium.org/12684005/diff/1/chrome/browser/ui/libgtk2ui/s...
File chrome/browser/ui/libgtk2ui/skia_utils_gtk2.cc (right):

https://codereview.chromium.org/12684005/diff/1/chrome/browser/ui/libgtk2ui/s...
chrome/browser/ui/libgtk2ui/skia_utils_gtk2.cc:25: (guint16)(SkColorGetR(color)
* kSkiaToGDKMultiplier),
Please use C++ static_cast<> instead of old c style casts
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Casting).

(As a side note, gobject's casts that are behind macros, like GTK_WIDGET(), are
ok to use.)

[Bobby Powers, 2013-03-14 17:01:34]

Ah, yes.  I'm still somewhat stuck in my C roots.  PTAL.

[Elliot Glaysher, 2013-03-14 17:02:39]

lgtm

[commit-bot: I haz the power, 2013-03-14 17:05:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bobbypowers@gmail.com/12684005/5001

[commit-bot: I haz the power, 2013-03-14 17:05:46]

Presubmit check for 12684005-5001 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/browser/ui/libgtk2ui/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ui/libgtk2ui/skia_utils_gtk2.cc

Presubmit checks took 2.8s to calculate.

[Elliot Glaysher, 2013-03-14 17:07:36]

sky, could you please stamp this patch? I'll get an OWNERS file in the libgtk2ui
directory to you later today so you don't have to stamp everything here.

[sky, 2013-03-14 19:46:34]

LGTM

[commit-bot: I haz the power, 2013-03-14 19:54:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bobbypowers@gmail.com/12684005/5001

[commit-bot: I haz the power, 2013-03-15 12:00:30]

Change committed as 188351

[Bobby Powers, 2013-03-15 13:09:00]

On 2013/03/15 12:00:30, I haz the power (commit-bot) wrote:
> Change committed as 188351

awesome, thank you two!