Issue 12683006: Files.app: prevent unlimited recursive directory traversal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12683006: Files.app: prevent unlimited recursive directory traversal (Closed)

Created:
7 years, 9 months ago by yoshiki

Modified:
7 years, 9 months ago

Reviewers:
kinaba

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: prevent unlimited recursive directory traversal Previously, a directory traversal on the left directory tree is not limited because of a wrong condition. This patch fixes it. BUG=none TEST=manual TBR=kinaba@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190522

Patch Set 1 #

Patch Set 2 : . #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/sidebar.js	View	1	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yoshiki

@kinaba: could you take a look? This patch fixes the problem we talked before.

7 years, 9 months ago (2013-03-25 05:57:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12683006/1

7 years, 9 months ago (2013-03-25 06:09:47 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=96550

7 years, 9 months ago (2013-03-25 08:23:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12683006/19001

7 years, 9 months ago (2013-03-26 00:00:59 UTC) #5

Message was sent while issue was closed.

Change committed as 190522

Expand Messages | Collapse Messages