net/dns/host_resolver_impl_unittest.cc - Issue 12681017: [net/dns] When serving AF_UNSPEC addresses from DnsHosts, serve one from each family.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl_unittest.cc

Issue 12681017: [net/dns] When serving AF_UNSPEC addresses from DnsHosts, serve one from each family. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move comment and ->clear Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/host_resolver_impl_unittest.cc

diff --git a/net/dns/host_resolver_impl_unittest.cc b/net/dns/host_resolver_impl_unittest.cc

index 4880b65fad085c28d525248386800631420a181d..c9ebec0140be6fc7ed423ce39000f804a4aff882 100644

--- a/net/dns/host_resolver_impl_unittest.cc

+++ b/net/dns/host_resolver_impl_unittest.cc

@@ -1375,8 +1375,8 @@ TEST_F(HostResolverImplDnsTest, ServeFromHosts) {

Request* req3 = CreateRequest("er_both", 80);

EXPECT_EQ(OK, req3->Resolve());

- EXPECT_TRUE(req3->HasOneAddress("127.0.0.1", 80) ||

- req3->HasOneAddress("::1", 80));

+ EXPECT_TRUE(req3->HasAddress("127.0.0.1", 80) &&

+ req3->HasAddress("::1", 80));

// Requests with specified AddressFamily.

Request* req4 = CreateRequest("er_ipv4", 80, MEDIUM, ADDRESS_FAMILY_IPV4);

« no previous file with comments | « net/dns/host_resolver_impl.cc ('k') | no next file » | no next file with comments »