Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: chrome/browser/extensions/app_sync_data_unittest.cc

Issue 12680004: Remove chrome/ code to handle App Notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/app_sync_data.cc ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/app_sync_data_unittest.cc
diff --git a/chrome/browser/extensions/app_sync_data_unittest.cc b/chrome/browser/extensions/app_sync_data_unittest.cc
index 64a9ab914c5258dd1fa1a66b7b5664ca8d5fe0bc..c32a56d4bc9b5d877afaad0f847f7a871de013f5 100644
--- a/chrome/browser/extensions/app_sync_data_unittest.cc
+++ b/chrome/browser/extensions/app_sync_data_unittest.cc
@@ -45,10 +45,6 @@ TEST_F(AppSyncDataTest, SyncDataToExtensionSyncDataForApp) {
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
app_specifics->set_page_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
- sync_pb::AppNotificationSettings* notif_settings =
- app_specifics->mutable_notification_settings();
- notif_settings->set_oauth_client_id(kOAuthClientId);
- notif_settings->set_disabled(true);
SetRequiredExtensionValues(app_specifics->mutable_extension());
@@ -60,10 +56,6 @@ TEST_F(AppSyncDataTest, SyncDataToExtensionSyncDataForApp) {
app_sync_data.app_launch_ordinal().ToInternalValue());
EXPECT_EQ(app_specifics->page_ordinal(),
app_sync_data.page_ordinal().ToInternalValue());
- EXPECT_EQ(notif_settings->oauth_client_id(),
- app_sync_data.notifications_client_id());
- EXPECT_EQ(notif_settings->disabled(),
- app_sync_data.notifications_disabled());
}
@@ -75,10 +67,6 @@ TEST_F(AppSyncDataTest, ExtensionSyncDataToSyncDataForApp) {
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
input_specifics->set_page_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
- sync_pb::AppNotificationSettings* notif_settings =
- input_specifics->mutable_notification_settings();
- notif_settings->set_oauth_client_id(kOAuthClientId);
- notif_settings->set_disabled(true);
SetRequiredExtensionValues(input_specifics->mutable_extension());
@@ -102,11 +90,6 @@ TEST_F(AppSyncDataTest, ExtensionSyncDataInvalidOrdinal) {
app_specifics->set_app_launch_ordinal("");
app_specifics->set_page_ordinal("");
- sync_pb::AppNotificationSettings* notif_settings =
- app_specifics->mutable_notification_settings();
- notif_settings->set_oauth_client_id(kOAuthClientId);
- notif_settings->set_disabled(true);
-
SetRequiredExtensionValues(app_specifics->mutable_extension());
syncer::SyncData sync_data =
« no previous file with comments | « chrome/browser/extensions/app_sync_data.cc ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698