Adds animation on a hovered directory/volume when dragging files in Files.app

Adds animation on a hovered directory/volume when dragging files in Files.app

To give more visible feedback, an animation has been added. The target directory blinks three times before it is opened. Along the way, now the directories which can't accept files are not openable.

TEST=Drag a file to some directory on a different volume.
BUG=137980
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187245

[mtomasz, 2013-03-08 04:59:47]

@yoshiki: PTAL.

[yoshiki, 2013-03-08 08:10:38]

https://chromiumcodereview.appspot.com/12677002/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://chromiumcodereview.appspot.com/12677002/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:427:
opt_destinationPath) {
Could you add @param annotations?

https://chromiumcodereview.appspot.com/12677002/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:435:
this.canPasteOrDrop_(opt_dataTransfer, opt_destinationPath)) {
The first argument of |canPasteOrDrop_| seems not to accept undefined. But
|opt_dataTransfer| may be undefined. Should you add undefined-check?

https://chromiumcodereview.appspot.com/12677002/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:454:
this.canPasteOrDrop_(opt_dataTransfer, opt_destinationPath)) {
ditto.

https://chromiumcodereview.appspot.com/12677002/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:577:
canPasteOrDrop_: function(dataTransfer, opt_destinationPath) {
Could you add @param annotations?

[mtomasz, 2013-03-11 03:17:50]

@yoshiki: I've addressed your comments. PTAL one more time.

https://codereview.chromium.org/12677002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/12677002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:427:
opt_destinationPath) {
On 2013/03/08 08:10:38, yoshiki wrote:
> Could you add @param annotations?

Done.

https://codereview.chromium.org/12677002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:435:
this.canPasteOrDrop_(opt_dataTransfer, opt_destinationPath)) {
On 2013/03/08 08:10:38, yoshiki wrote:
> The first argument of |canPasteOrDrop_| seems not to accept undefined. But
> |opt_dataTransfer| may be undefined. Should you add undefined-check?

Done.

https://codereview.chromium.org/12677002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:454:
this.canPasteOrDrop_(opt_dataTransfer, opt_destinationPath)) {
On 2013/03/08 08:10:38, yoshiki wrote:
> ditto.

Done.

https://codereview.chromium.org/12677002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:577:
canPasteOrDrop_: function(dataTransfer, opt_destinationPath) {
On 2013/03/08 08:10:38, yoshiki wrote:
> Could you add @param annotations?

Done.

[yoshiki, 2013-03-11 03:56:28]

lgtm

[commit-bot: I haz the power, 2013-03-11 04:16:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12677002/4001

[commit-bot: I haz the power, 2013-03-11 07:12:08]

Change committed as 187245