Add PresubmitPromptOrNotify helper.

Add PresubmitPromptOrNotify helper.

PresubmitPromptOrNotify prints the message and prompts the user only
if the presubmit is on upload, not commit.

This is useful to provide upload-time sanity checks without blocking
the CL from being landed via the commit-queue.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=190711

[Wez, 2013-03-23 03:23:33]

PTAL

[Jói, 2013-03-23 08:51:26]

LGTM

[Wez, 2013-03-25 17:12:12]

Do I need to land this manually with git cl dcommit?

[M-A Ruel, 2013-03-25 17:32:44]

You can use the CQ, but please fix this before.

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.py
File presubmit_support.py (right):

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:169: def PresubmitPromptOrNotify(self, message, items=None,
long_text=''):
def PresubmitPromptOrNotify(self, *args, **kwargs):

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:172: return self.PresubmitNotifyResult(message, items,
long_text)
return self.PresubmitNotifyResult(*args, **kwargs)

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:173: return self.PresubmitPromptWarning(message, items,
long_text)
same

[Wez, 2013-03-26 17:28:49]

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.py
File presubmit_support.py (right):

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:169: def PresubmitPromptOrNotify(self, message, items=None,
long_text=''):
On 2013/03/25 17:32:44, Marc-Antoine Ruel wrote:
> def PresubmitPromptOrNotify(self, *args, **kwargs):

Done.

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:172: return self.PresubmitNotifyResult(message, items,
long_text)
On 2013/03/25 17:32:44, Marc-Antoine Ruel wrote:
> return self.PresubmitNotifyResult(*args, **kwargs)

Done.

https://chromiumcodereview.appspot.com/12676031/diff/2001/presubmit_support.p...
presubmit_support.py:173: return self.PresubmitPromptWarning(message, items,
long_text)
On 2013/03/25 17:32:44, Marc-Antoine Ruel wrote:
> same

Done.

[commit-bot: I haz the power, 2013-03-26 17:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/12676031/8001

[commit-bot: I haz the power, 2013-03-26 17:31:50]

Change committed as 190711