Skip default categories when getting known categories.

Skip default categories when getting known categories.

We don't want to see the default categories when we get the known
categories as they aren't tracing categories that the user will
care about.

BUG=195661
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190675

[dsinclair, 2013-03-22 02:01:04]

PTAL.

[nduca, 2013-03-23 01:09:00]

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:77: const int g_category_defined_start = 3;
this name is a bit awk. Skip builtin categories maybe?

SHould we just make the categories that begin with _ be not returned? The
strings used for the category names are not often printed, so it seems safe to
just have them start with underscores.

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_unitte...
File base/debug/trace_event_unittest.cc (right):

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_unitte...
base/debug/trace_event_unittest.cc:866: // Can't check the length as I don't
know what other categories may have
thats fine, but skip the first person voice and stick with the "make sure
metadata isn't returned"

[dsinclair, 2013-03-25 14:22:57]

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:77: const int g_category_defined_start = 3;
On 2013/03/23 01:09:00, nduca wrote:
> this name is a bit awk. Skip builtin categories maybe?
> 
> SHould we just make the categories that begin with _ be not returned? The
> strings used for the category names are not often printed, so it seems safe to
> just have them start with underscores.

Changed to 'g_skip_builtin_categories'.

I think for now, what we have works. If we find we need to add more of these
default categories we can switch to the __ skipping scheme in the future.

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_unitte...
File base/debug/trace_event_unittest.cc (right):

https://codereview.chromium.org/12676007/diff/1/base/debug/trace_event_unitte...
base/debug/trace_event_unittest.cc:866: // Can't check the length as I don't
know what other categories may have
On 2013/03/23 01:09:00, nduca wrote:
> thats fine, but skip the first person voice and stick with the "make sure
> metadata isn't returned"

Done.

[nduca, 2013-03-25 18:30:03]

LGTM

https://codereview.chromium.org/12676007/diff/4002/base/debug/trace_event_imp...
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/4002/base/debug/trace_event_imp...
base/debug/trace_event_impl.cc:77: const int g_skip_builtin_categories = 3;
g_num_builtin_categories? sorry to be wordsmithing you...

[dsinclair, 2013-03-25 19:10:26]

jar@, can you please take a look for base OWNERS.

Thanks,
dan

https://codereview.chromium.org/12676007/diff/4002/base/debug/trace_event_imp...
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/4002/base/debug/trace_event_imp...
base/debug/trace_event_impl.cc:77: const int g_skip_builtin_categories = 3;
On 2013/03/25 18:30:03, nduca wrote:
> g_num_builtin_categories? sorry to be wordsmithing you...

Done.

[jar (doing other things), 2013-03-25 19:15:24]

LGTM (tiny tiny nit below).

https://codereview.chromium.org/12676007/diff/10001/base/debug/trace_event_im...
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/10001/base/debug/trace_event_im...
base/debug/trace_event_impl.cc:78: int g_category_index =
g_num_builtin_categories; // skip default categories.
nit: Capitalize start of comment sentences.

[dsinclair, 2013-03-25 19:22:28]

https://codereview.chromium.org/12676007/diff/10001/base/debug/trace_event_im...
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/12676007/diff/10001/base/debug/trace_event_im...
base/debug/trace_event_impl.cc:78: int g_category_index =
g_num_builtin_categories; // skip default categories.
On 2013/03/25 19:15:25, jar wrote:
> nit: Capitalize start of comment sentences.

Done.

[commit-bot: I haz the power, 2013-03-25 19:25:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12676007/16001

[commit-bot: I haz the power, 2013-03-26 00:06:43]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-26 13:38:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12676007/16001

[commit-bot: I haz the power, 2013-03-26 13:50:06]

Change committed as 190675