Added the reply/loop icon to the video player.

chrome/browser/resources/file_manager/js/media/media_controls.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview MediaControls class implements media playback controls
  * that exist outside of the audio/video HTML element.
  */
 
 /**
@@ skipping 52 matching lines @@
   parent.appendChild(control);
   return control;
 };
 
 /**
  * Create a custom button.
  *
  * @param {string} className Class name.
  * @param {function(Event)} handler Click handler.
  * @param {HTMLElement=} opt_parent Parent element or container if undefined.
- * @param {boolean=} opt_toggle True if the button has toggle state.
+ * @param {number=} opt_numStates Number of states, default: 1.

[yoshiki, 2013/03/08 08:20:07]

Expressing the status as a raw number is difficult to understand. Could you
create an enum to express the status and use it? (as enum's in file_manager.js)

[mtomasz, 2013/03/11 03:47:16]

Done.

  * @return {HTMLElement} The new button element.
  */
 MediaControls.prototype.createButton = function(
-    className, handler, opt_parent, opt_toggle) {
+    className, handler, opt_parent, opt_numStates) {
+  opt_numStates = opt_numStates || 1;

[yoshiki, 2013/03/08 08:20:07]

nit: |opt_numStates| is no longer optional. Please rename.

var numStates = opt_numStates || 1;

[mtomasz, 2013/03/08 09:10:00]

We use this pattern very often. opt_sth = opt_sth || default_value. Do we really
want an additional variable for every optional argument? If so, then we have to
change it in tons of places. 

[yoshiki, 2013/03/11 01:45:32]

I prefer adding additional value, but it's not strong feeling. I will leave the
choice to you.

On 2013/03/08 09:10:00, mtomasz wrote:

[mtomasz, 2013/03/11 03:47:16]

The reason I'd prefer this is that I don't think there is something wrong in
setting a default value to an optional argument. This trick opt_x = opt_x ||
default_value is an emulation of function(opt_argument = default_value), which
is not supported in Javascript, but it is in eg. C++. We used this trick
extensively in my previous project. Moreover, creating a second variable x =
opt_x || default_value causes having two variables x and opt_x, which can be bug
prone. Anyway, I'll leave it as it is for now, but I am open to discuss in the
future about it. Done.

[yoshiki, 2013/03/11 04:42:45]

Ok, let's leave it as it is. 

But the code may be warned by closure compiler, because it does implicit
type-cast from |Type=| (undefined-able) to |Type| (non-undefined-able). Perhaps,
I'll do bulk-replace when applying closure compiler in the feature.

On 2013/03/11 03:47:16, mtomasz wrote:

+
   var button = this.createControl(className, opt_parent);
   button.classList.add('media-button');
   button.addEventListener('click', handler);
 
-  var numStates = opt_toggle ? 2 : 1;
-  for (var state = 0; state != numStates; state++) {
+  for (var state = 0; state != opt_numStates; state++) {
     var stateClass = 'state' + state;
     this.createControl('normal ' + stateClass, button);
     this.createControl('hover ' + stateClass, button);
     this.createControl('active ' + stateClass, button);
   }
   this.createControl('disabled', button);
 
   button.setAttribute('state', 0);
   button.addEventListener('click', handler);
   return button;
@@ skipping 50 matching lines @@
     this.pause();
   else
     this.play();
 };
 
 /**
  * @param {HTMLElement=} opt_parent Parent container.
  */
 MediaControls.prototype.initPlayButton = function(opt_parent) {
   this.playButton_ = this.createButton('play media-control',
-      this.togglePlayState.bind(this), opt_parent, true /* toggle */);
+      this.togglePlayState.bind(this), opt_parent, 3 /* States. */);
 };
 
 /*
  * Time controls
  */
 
 /**
  * The default range of 100 is too coarse for the media progress slider.
  */
 MediaControls.PROGRESS_RANGE = 5000;
@@ skipping 59 matching lines @@
   if (on) {
     this.resumeAfterDrag_ = this.isPlaying();
     this.media_.pause();
   } else {
     if (this.resumeAfterDrag_) {
       if (this.media_.ended)
         this.onMediaPlay_(false);
       else
         this.media_.play();
     }
+    this.updatePlayButtonState_(this.isPlaying());
   }
 };
 
 /*
  * Volume controls
  */
 
 /**
  * @param {HTMLElement=} opt_parent Parent element for the controls.
  */
@@ skipping 114 matching lines @@
 
 /**
  * 'play' and 'pause' event handler.
  * @param {boolean} playing True if playing.
  * @private
  */
 MediaControls.prototype.onMediaPlay_ = function(playing) {
   if (this.progressSlider_.isDragging())
     return;
 
-  this.playButton_.setAttribute('state', playing ? '1' : '0');
+  this.updatePlayButtonState_(playing);
   this.onPlayStateChanged();
 };
 
 /**
  * 'durationchange' event handler.
  * @private
  */
 MediaControls.prototype.onMediaDuration_ = function() {
   if (!this.media_.duration) {
     this.enableControls_('.media-control', false);
@@ skipping 50 matching lines @@
  */
 MediaControls.prototype.onMediaComplete = function() {};
 
 /**
  * Called when play/pause state is changed or on playback progress.
  * This is the right moment to save the play state.
  */
 MediaControls.prototype.onPlayStateChanged = function() {};
 
 /**
+ * Updates the play button state.
+ * @param {boolean} playing If the video is playing.
+ * @private
+ */
+MediaControls.prototype.updatePlayButtonState_ = function(playing) {
+  if (playing) {
+    this.playButton_.setAttribute('state', '1');  // Pause icon.
+  } else if (!this.media_.ended) {
+    this.playButton_.setAttribute('state', '0');  // Play icon.
+  } else {
+    this.playButton_.setAttribute('state', '2');  // Replay icon.
+  }
+};
+
+/**
  * Restore play state. Base implementation is empty.
  */
 MediaControls.prototype.restorePlayState = function() {};
 
 /**
  * Encode current state into the page URL or the app state.
  */
 MediaControls.prototype.encodeState = function() {
   if (!this.media_.duration)
     return;
@@ skipping 683 matching lines @@
 AudioControls.prototype.onAdvanceClick_ = function(forward) {
   if (!forward &&
       (this.getMedia().currentTime > AudioControls.TRACK_RESTART_THRESHOLD)) {
     // We are far enough from the beginning of the current track.
     // Restart it instead of than skipping to the previous one.
     this.getMedia().currentTime = 0;
   } else {
     this.advanceTrack_(forward);
   }
 };