Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 12674029: Chromify layer_impl_unittest.cc (Closed)

Created:
7 years, 9 months ago by ajuma
Modified:
7 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, jamesr
Visibility:
Public.

Description

Chromify layer_impl_unittest.cc BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190119

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix floats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -227 lines) Patch
M cc/layers/layer_impl_unittest.cc View 1 1 chunk +274 lines, -227 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ajuma
7 years, 9 months ago (2013-03-22 15:01:13 UTC) #1
danakj
LGTM https://codereview.chromium.org/12674029/diff/1/cc/layers/layer_impl_unittest.cc File cc/layers/layer_impl_unittest.cc (right): https://codereview.chromium.org/12674029/diff/1/cc/layers/layer_impl_unittest.cc#newcode103 cc/layers/layer_impl_unittest.cc:103: arbitrary_filters.append(WebFilterOperation::createOpacityFilter(0.5)); float https://codereview.chromium.org/12674029/diff/1/cc/layers/layer_impl_unittest.cc#newcode218 cc/layers/layer_impl_unittest.cc:218: arbitrary_filters.append(WebFilterOperation::createOpacityFilter(0.5)); float
7 years, 9 months ago (2013-03-22 15:51:34 UTC) #2
ajuma
https://codereview.chromium.org/12674029/diff/1/cc/layers/layer_impl_unittest.cc File cc/layers/layer_impl_unittest.cc (right): https://codereview.chromium.org/12674029/diff/1/cc/layers/layer_impl_unittest.cc#newcode103 cc/layers/layer_impl_unittest.cc:103: arbitrary_filters.append(WebFilterOperation::createOpacityFilter(0.5)); On 2013/03/22 15:51:34, danakj wrote: > float Done. ...
7 years, 9 months ago (2013-03-22 15:55:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12674029/4001
7 years, 9 months ago (2013-03-22 15:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12674029/4001
7 years, 9 months ago (2013-03-22 18:30:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12674029/4001
7 years, 9 months ago (2013-03-23 15:16:13 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 23:40:28 UTC) #7
Message was sent while issue was closed.
Change committed as 190119

Powered by Google App Engine
This is Rietveld 408576698