Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12674027: Correctly materialize arguments object in Runtime_DebugEvaluate. (Closed)

Created:
7 years, 9 months ago by Yang
Modified:
7 years, 9 months ago
Reviewers:
Peter Rybin
CC:
v8-dev
Visibility:
Public.

Description

Correctly materialize arguments object in Runtime_DebugEvaluate. The problem was that if the # arguments specified in the function declaration and the # arguments passed to the function are not the same, we use an arguments adapter frame to make it work. This confuses the existing implementation to materialize the arguments object. R=peter.rybin@gmail.com BUG=222893 Committed: https://code.google.com/p/v8/source/detail?r=14059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/runtime.cc View 1 chunk +4 lines, -13 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-222893.js View 1 chunk +22 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 9 months ago (2013-03-22 11:50:45 UTC) #1
Peter Rybin
LGTM I also have couple of comments about apply 1. My patch utility failed to ...
7 years, 9 months ago (2013-03-23 04:17:41 UTC) #2
Yang
On 2013/03/23 04:17:41, Peter Rybin wrote: > LGTM > > I also have couple of ...
7 years, 9 months ago (2013-03-25 10:01:11 UTC) #3
Yang
7 years, 9 months ago (2013-03-25 10:02:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698