Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12674019: Alternate NTP Mac: Show overlay at fixed position (Closed)

Created:
7 years, 9 months ago by sail
Modified:
7 years, 9 months ago
Reviewers:
sky, kuan, dhollowa
CC:
chromium-reviews, tfarina, dcheng, sail+watch_chromium.org
Visibility:
Public.

Description

Alternate NTP Mac: Show overlay at fixed position Previously the overlay was shown at the bottom of the toolbar. The height of the bookmark bar changes if the bookmark bar is attached. This meant that the overlay would change positions (relative to the omnibox) depending on the bookmark bar's attached state. With this CL we now show the overlay at the fixed offset from the omnibox. One side effect of this is that the bottom of the toolbar can no longer act as a separator for the overlay. I've changed the overlay to draw its own separator. Screenshot: http://i.imgur.com/ub9gfDo.png BUG=173475, 174077 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190519 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190584

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : " #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : fix undocked dev tools #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -114 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h View 1 2 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +21 lines, -4 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.mm View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view_unittest.mm View 1 chunk +0 lines, -27 lines 0 comments Download
A chrome/browser/ui/cocoa/tab_contents/overlay_separator_view.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/overlay_separator_view.mm View 1 chunk +18 lines, -2 lines 0 comments Download
A chrome/browser/ui/cocoa/tab_contents/overlay_separator_view_unittest.mm View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +41 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (0 generated)
sail
7 years, 9 months ago (2013-03-22 02:09:48 UTC) #1
dhollowa
lgtm
7 years, 9 months ago (2013-03-22 16:21:20 UTC) #2
kuan
lgtm.
7 years, 9 months ago (2013-03-22 16:26:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/2001
7 years, 9 months ago (2013-03-22 16:29:12 UTC) #4
commit-bot: I haz the power
Presubmit check for 12674019-2001 failed and returned exit status 1. INFO:root:Found 10 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-22 16:29:28 UTC) #5
sail
TBRing sky for trivial gypi changes.
7 years, 9 months ago (2013-03-22 16:39:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/2001
7 years, 9 months ago (2013-03-22 16:39:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/12002
7 years, 9 months ago (2013-03-22 18:30:37 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-22 20:05:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/15003
7 years, 9 months ago (2013-03-22 20:09:17 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-22 22:10:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/28001
7 years, 9 months ago (2013-03-22 22:11:20 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-23 01:31:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/44002
7 years, 9 months ago (2013-03-23 12:50:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/44002
7 years, 9 months ago (2013-03-23 15:15:58 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-23 16:17:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/57004
7 years, 9 months ago (2013-03-23 17:41:04 UTC) #17
commit-bot: I haz the power
Failed to trigger a try job on mac_rel HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-23 17:52:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/61003
7 years, 9 months ago (2013-03-23 17:53:22 UTC) #19
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=111961
7 years, 9 months ago (2013-03-23 18:43:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/61003
7 years, 9 months ago (2013-03-23 18:46:35 UTC) #21
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=111968
7 years, 9 months ago (2013-03-23 19:40:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/57007
7 years, 9 months ago (2013-03-23 23:38:43 UTC) #23
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=110720
7 years, 9 months ago (2013-03-24 00:20:46 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/49009
7 years, 9 months ago (2013-03-24 00:33:09 UTC) #25
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromedriver2_unittests, components_unittests, ...
7 years, 9 months ago (2013-03-24 02:43:59 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/49009
7 years, 9 months ago (2013-03-24 02:58:28 UTC) #27
commit-bot: I haz the power
Change committed as 190213
7 years, 9 months ago (2013-03-24 05:36:44 UTC) #28
sail
Hey David and Kuan, could you take another looks at this CL. Changes since your ...
7 years, 9 months ago (2013-03-25 18:21:36 UTC) #29
dhollowa
lgtm
7 years, 9 months ago (2013-03-25 18:26:32 UTC) #30
kuan
lgtm.
7 years, 9 months ago (2013-03-25 18:27:52 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/64001
7 years, 9 months ago (2013-03-25 18:35:18 UTC) #32
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=112342
7 years, 9 months ago (2013-03-25 20:51:02 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/86001
7 years, 9 months ago (2013-03-25 22:01:12 UTC) #34
sail
Committed patchset #13 manually as r190519 (presubmit successful).
7 years, 9 months ago (2013-03-26 00:15:53 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/98001
7 years, 9 months ago (2013-03-26 01:25:20 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12674019/98001
7 years, 9 months ago (2013-03-26 07:00:18 UTC) #37
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 08:03:43 UTC) #38
Message was sent while issue was closed. 
Change committed as 190584

Powered by Google App Engine
This is Rietveld 408576698