Fix playing video files with hash in the filename in Files.app.

Fix playing video files with hash in the filename in Files.app.

File names are passed via url. Because of faulty escaping, hash in the filename was causing interpreting part of the filename as url's hash part. This patch fixes it by properly escaping the hash character.

TEST=Play a local video with a hash character in the filename.
BUG=171987
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187276

[mtomasz, 2013-03-08 07:05:59]

@hashimoto: PTAL.

[hashimoto, 2013-03-08 07:12:46]

https://codereview.chromium.org/12674003/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager_util.cc (right):

https://codereview.chromium.org/12674003/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager_util.cc:621:
net::EscapeUrlEncodedData(virtual_path.value(), false));
boolean arguments are hard to read. (see "nullptr/NULL, true/false, 1, 2, 3..."
section of
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Implem...)

Could you clarify what "false" here mean?

[mtomasz, 2013-03-11 03:54:28]

https://codereview.chromium.org/12674003/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager_util.cc (right):

https://codereview.chromium.org/12674003/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager_util.cc:621:
net::EscapeUrlEncodedData(virtual_path.value(), false));
On 2013/03/08 07:12:47, hashimoto wrote:
> boolean arguments are hard to read. (see "nullptr/NULL, true/false, 1, 2,
3..."
> section of
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Implem...)
> 
> Could you clarify what "false" here mean?

Added comments. Done.

[hashimoto, 2013-03-11 04:12:58]

lgtm

[commit-bot: I haz the power, 2013-03-11 04:17:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12674003/5001

[commit-bot: I haz the power, 2013-03-11 04:32:32]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-11 08:51:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12674003/5001

[commit-bot: I haz the power, 2013-03-11 11:52:32]

Change committed as 187276

[yoshiki, 2013-03-26 11:44:50]

https://chromiumcodereview.appspot.com/12674003/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/extensions/file_manager_util.cc (right):

https://chromiumcodereview.appspot.com/12674003/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/extensions/file_manager_util.cc:417: url += "#/" +
Should we use "#%2F" instead of "#/", because the path is now encoded by
encodeURIcomponent(), not encodeURI()?

https://chromiumcodereview.appspot.com/12674003/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/extensions/file_manager_util.cc:784: url += "#/" +
net::EscapeUrlEncodedData(virtual_path.value(),
ditto