Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12672008: Move xkeyboard.cc from c/b/chromeos/input_method to chromeos/ime (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move xkeyboard.cc from c/b/chromeos/input_method to chromeos/ime BUG=164375 TEST=None TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191535

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -880 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/mock_xkeyboard.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/input_method/mock_xkeyboard.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/input_method/xkeyboard.h View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/chromeos/input_method/xkeyboard.cc View 1 2 1 chunk +0 lines, -378 lines 0 comments Download
D chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 1 1 chunk +0 lines, -213 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/caps_lock_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/caps_lock_delegate_chromeos_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
A + chromeos/ime/mock_xkeyboard.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chromeos/ime/mock_xkeyboard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/ime/xkeyboard.h View 4 chunks +13 lines, -10 lines 0 comments Download
A + chromeos/ime/xkeyboard.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/ime/xkeyboard_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-26 03:12:53 UTC) #1
satorux1
LGTM
7 years, 9 months ago (2013-03-26 03:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12672008/7001
7 years, 8 months ago (2013-03-30 15:51:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 12672008-7001 failed and returned exit status 1. INFO:root:Found 24 file(s). Running presubmit ...
7 years, 8 months ago (2013-03-30 15:51:59 UTC) #4
Seigo Nonaka
TBR-ing for gypi files. And also TBR-ing for only changes the include path.
7 years, 8 months ago (2013-03-30 15:53:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12672008/7001
7 years, 8 months ago (2013-03-30 15:54:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12672008/7001
7 years, 8 months ago (2013-03-30 16:57:59 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 18:58:18 UTC) #8
Message was sent while issue was closed. 
Change committed as 191535

Powered by Google App Engine
This is Rietveld 408576698