Extend drover so it can revert any chrome revision.

Extend drover so it can revert any chrome revision.

* Use base chrome svn url for reverts to work with
branches and tools repos.
* Add heuristic to drover so it can search multiple
svn repos for the likely revision to revert.

Each of chrome, chrome-internal, native_client are separated by
more than 20k revisions, so we can programmatically determine
which repo the user wants to revert with high confidence.

TESTS=
- pylint (part of presubmit)
- tried recent tools/build chrome revision
- tried NaCl revision
- tried NaCl revision with --no-alt-urls (got rev from chrome)
- tried NaCl without valid svn credentials (got rev from chrome)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=188792

[cmp, 2013-03-16 23:01:23]

Isaac, can you modify the CL description with "TESTS=..." to describe the manual
tests you ran?

[Isaac (away), 2013-03-16 23:07:38]

On 2013/03/16 23:01:23, cmp wrote:
> Isaac, can you modify the CL description with "TESTS=..." to describe the
manual
> tests you ran?

Sure.  Done.

[M-A Ruel, 2013-03-18 17:09:36]

lgtm

https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py#newcode549
drover.py:549: if 0 <= url_rev - options.revert < 20000:
Maybe 10000 to be on the safer side?

[laforge, 2013-03-18 17:48:22]

LGTM
On 2013/03/18 17:09:36, Marc-Antoine Ruel wrote:
> lgtm
> 
> https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py
> File drover.py (right):
> 
> https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py#newcode549
> drover.py:549: if 0 <= url_rev - options.revert < 20000:
> Maybe 10000 to be on the safer side?

[Isaac (away), 2013-03-18 19:25:59]

M-A, could you take another look?

https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12670008/diff/6002/drover.py#newcode549
drover.py:549: if 0 <= url_rev - options.revert < 20000:
On 2013/03/18 17:09:37, Marc-Antoine Ruel wrote:
> Maybe 10000 to be on the safer side?

I started w/ 10000 but it's only 2 months of chromium. The issue is that 20k
revisions means different things for different repos.  So I have changed this
heuristic to use <120 days since commit instead of revision difference.

If we want to add more repos that might have conflicts, we can improve change
the heuristic to read multiple or maybe ask multiple times in the prompt "Is
this the correct revision" below.  For now I think it is sufficient.

[M-A Ruel, 2013-03-18 19:28:19]

On 2013/03/18 19:25:59, Isaac wrote:
> So I have changed this
> heuristic to use <120 days since commit instead of revision difference.

I much prefer that. Thanks.

lgtm

[commit-bot: I haz the power, 2013-03-18 19:32:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12670008/6004

[commit-bot: I haz the power, 2013-03-18 19:35:11]

Change committed as 188792