tools/perf/benchmarks/benchmark_smoke_unittest.py - Issue 1266833004: telemetry: Add a page set for blink's memory usage measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 1266833004: telemetry: Add a page set for blink's memory usage measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_smoke_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py

index 31a0d8e409908d35b2a23b79eacc57b03ea382ed..4170b732c8bcfca26dec455c56a75582c4396fb5 100644

--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py

+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py

@@ -150,6 +150,10 @@ def load_tests(loader, standard_tests, pattern):

if sys.modules[benchmark.__module__] in _ANDROID_BLACK_LIST_MODULES:

method._disabled_strings.append('android')

+ # TODO(bashi): Remove once crrev.com/1266833004 is landed.

+ if benchmark.Name() == 'memory.blink_memory_mobile':

+ method._disabled_strings.append('android')

setattr(BenchmarkSmokeTest, benchmark.Name(), method)

suite.addTest(BenchmarkSmokeTest(benchmark.Name()))

« no previous file with comments | « no previous file | tools/perf/benchmarks/memory_benchmark.py » ('j') | no next file with comments »