Issue 12668007: fix window's build errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12668007: fix window's build errors (Closed)

Created:
7 years, 9 months ago by djsollen

Modified:
7 years, 9 months ago

Reviewers:
borenet, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix window's build errors Committed: http://code.google.com/p/skia/source/detail?r=8158

Patch Set 2 : address mike's comment #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	include/images/SkBitmapRegionDecoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/images/SkImageDecoder_libwebp.cpp	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm w/ one fix https://codereview.chromium.org/12668007/diff/1/src/images/SkImageDecoder_libwebp.cpp File src/images/SkImageDecoder_libwebp.cpp (right): https://codereview.chromium.org/12668007/diff/1/src/images/SkImageDecoder_libwebp.cpp#newcode273 src/images/SkImageDecoder_libwebp.cpp:273: SkBitmap::Config config = this->getPrefConfig(k32Bit_SrcDepth, (bool) ...

7 years, 9 months ago (2013-03-14 15:03:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/12668007/5001

7 years, 9 months ago (2013-03-14 15:18:04 UTC) #3

Message was sent while issue was closed.

Change committed as 8158

Expand Messages | Collapse Messages

Issue 12668007: fix window's build errors (Closed)

Description

Patch Set 1 #

Patch Set 2 : address mike's comment #

Messages