Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4557)

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_win.cc

Issue 12667018: Switch Windows to use the MessagePopupCollection (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/message_center/web_notification_tray_win.cc
diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_win.cc b/chrome/browser/ui/views/message_center/web_notification_tray_win.cc
index d2f77c6565f1b6c7ae7247777a0065bea36cd39f..f6974be6efadcdfc2d2ac61878a043f5f0b7d02d 100644
--- a/chrome/browser/ui/views/message_center/web_notification_tray_win.cc
+++ b/chrome/browser/ui/views/message_center/web_notification_tray_win.cc
@@ -25,7 +25,7 @@
#include "ui/message_center/message_center_tray_delegate.h"
#include "ui/message_center/views/message_bubble_base.h"
#include "ui/message_center/views/message_center_bubble.h"
-#include "ui/message_center/views/message_popup_bubble.h"
+#include "ui/message_center/views/message_popup_collection.h"
#include "ui/views/widget/widget.h"
namespace {
@@ -116,17 +116,13 @@ message_center::MessageCenter* WebNotificationTrayWin::message_center() {
}
bool WebNotificationTrayWin::ShowPopups() {
- scoped_ptr<message_center::MessagePopupBubble> bubble(
- new message_center::MessagePopupBubble(message_center()));
- popup_bubble_.reset(new internal::NotificationBubbleWrapperWin(
- this,
- bubble.Pass(),
- internal::NotificationBubbleWrapperWin::BUBBLE_TYPE_POPUP));
+ popup_collection_.reset(
+ new message_center::MessagePopupCollection(NULL, message_center()));
return true;
}
void WebNotificationTrayWin::HidePopups() {
- popup_bubble_.reset();
+ popup_collection_.reset();
}
bool WebNotificationTrayWin::ShowMessageCenter() {
@@ -173,8 +169,8 @@ void WebNotificationTrayWin::UpdateMessageCenter() {
}
void WebNotificationTrayWin::UpdatePopups() {
- if (popup_bubble_.get())
- popup_bubble_->bubble()->ScheduleUpdate();
+ if (popup_collection_.get())
+ popup_collection_->UpdatePopups();
};
void WebNotificationTrayWin::OnMessageCenterTrayChanged() {
@@ -240,9 +236,6 @@ void WebNotificationTrayWin::HideBubbleWithView(
if (message_center_bubble_.get() &&
bubble_view == message_center_bubble_->bubble_view()) {
message_center_tray_->HideMessageCenterBubble();
- } else if (popup_bubble_.get() &&
- bubble_view == popup_bubble_->bubble_view()) {
- message_center_tray_->HidePopupBubble();
}
}
@@ -259,12 +252,4 @@ WebNotificationTrayWin::GetMessageCenterBubbleForTest() {
message_center_bubble_->bubble());
}
-message_center::MessagePopupBubble*
-WebNotificationTrayWin::GetPopupBubbleForTest() {
- if (!popup_bubble_.get())
- return NULL;
- return static_cast<message_center::MessagePopupBubble*>(
- popup_bubble_->bubble());
-}
-
} // namespace message_center

Powered by Google App Engine
This is Rietveld 408576698