Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: chrome/browser/sync_file_system/drive_file_sync_service.cc

Issue 12660020: SyncFS: Fix up DCHECK failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_file_sync_service.cc
diff --git a/chrome/browser/sync_file_system/drive_file_sync_service.cc b/chrome/browser/sync_file_system/drive_file_sync_service.cc
index 264aefa57ffd94d97b7eb1acabe2e7d9dae9762c..71c0e0ec6e0561056c382da73fd122c5b226fcb6 100644
--- a/chrome/browser/sync_file_system/drive_file_sync_service.cc
+++ b/chrome/browser/sync_file_system/drive_file_sync_service.cc
@@ -1226,7 +1226,7 @@ DriveFileSyncService::ResolveLocalSyncOperationType(
url, &remote_change);
if (has_remote_change) {
- if (param && !has_metadata)
+ if (param && param->drive_metadata.resource_id().empty())
param->drive_metadata.set_resource_id(remote_change.resource_id);
// Remote change for the file identified by |url| exists in the pending
@@ -1304,7 +1304,6 @@ void DriveFileSyncService::DidUploadNewFileForLocalSync(
const std::string& resource_id,
const std::string& file_md5) {
DCHECK(param);
- DCHECK(!param->has_drive_metadata);
const FileSystemURL& url = param->url;
if (error == google_apis::HTTP_CREATED) {
param->drive_metadata.set_resource_id(resource_id);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698