Issue 12660020: SyncFS: Fix up DCHECK failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12660020: SyncFS: Fix up DCHECK failures (Closed)

Created:
7 years, 9 months ago by kinuko

Modified:
7 years, 9 months ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, calvinlo

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

SyncFS: Fix up DCHECK failures 1. After r190443 now we may call UploadNewFileForLocalSync even for the files we have (stale) metadata 2. In auto conflict resolution we could have metadata that doesn't have resource_id in metadata_store while having a remote change for the file (thus resulting in a conflict) BUG=177626, 223415 TEST=manual NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190521

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/sync_file_system/drive_file_sync_service.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/12660020/1

7 years, 9 months ago (2013-03-26 00:06:48 UTC) #4

Message was sent while issue was closed.

Change committed as 190521

Expand Messages | Collapse Messages