Issue 12660013: Added BluetoothDeviceMac (empty implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12660013: Added BluetoothDeviceMac (empty implementation) (Closed)

Created:
7 years, 9 months ago by youngki

Modified:
7 years, 9 months ago

Reviewers:
keybuk

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added BluetoothDeviceMac (empty implementation) I added NOTIMPLEMENTED() to the methods which won't be supported in BluetoothDeviceMac. BUG=135472 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188894

Patch Set 1 #

Patch Set 2 : remove service_record_list_ which is not needed yet for the empty class. #

Patch Set 3 : I forgot to add ConfirmPairing() empty implementation. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -29 lines)			Patch
device/bluetooth/bluetooth_device_mac.h	View	1 2	2 chunks	+8 lines, -29 lines	0 comments	Download
device/bluetooth/bluetooth_device_mac.mm	View	1 2	1 chunk	+110 lines, -0 lines	0 comments	Download
device/device.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/youngki@chromium.org/12660013/2001

7 years, 9 months ago (2013-03-18 17:45:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, content_browsertests, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=123981

7 years, 9 months ago (2013-03-18 22:00:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/youngki@chromium.org/12660013/20001

7 years, 9 months ago (2013-03-18 22:30:07 UTC) #5

Message was sent while issue was closed.

Change committed as 188894

Expand Messages | Collapse Messages