Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 12658003: Do not create display_change_listener for parent=NULL. (Closed)

Created:
7 years, 9 months ago by Jun Mukai
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Do not create display_change_listener for parent=NULL. The status_icon_win is not backed by any widget, so it is natural to pass |parent| to NULL and it seems to make sense that it won't have display_change_listener in that case. BUG=181027 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187356

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/menu/menu_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
7 years, 9 months ago (2013-03-08 05:08:57 UTC) #1
dewittj
lgtm to fix 181027, but I don't really know anything about display_change_listeners.
7 years, 9 months ago (2013-03-08 17:57:43 UTC) #2
dewittj
On 2013/03/08 17:57:43, dewittj wrote: > lgtm to fix 181027, but I don't really know ...
7 years, 9 months ago (2013-03-08 18:29:32 UTC) #3
Jun Mukai
ben, can you review this? This would be a fix for win aura.
7 years, 9 months ago (2013-03-08 23:50:22 UTC) #4
Ben Goodger (Google)
lgtm https://codereview.chromium.org/12658003/diff/1/ui/views/controls/menu/menu_runner.cc File ui/views/controls/menu/menu_runner.cc (right): https://codereview.chromium.org/12658003/diff/1/ui/views/controls/menu/menu_runner.cc#newcode287 ui/views/controls/menu/menu_runner.cc:287: if ((types & (IS_NESTED | FOR_DROP)) == 0 ...
7 years, 9 months ago (2013-03-11 16:10:07 UTC) #5
Jun Mukai
https://codereview.chromium.org/12658003/diff/1/ui/views/controls/menu/menu_runner.cc File ui/views/controls/menu/menu_runner.cc (right): https://codereview.chromium.org/12658003/diff/1/ui/views/controls/menu/menu_runner.cc#newcode287 ui/views/controls/menu/menu_runner.cc:287: if ((types & (IS_NESTED | FOR_DROP)) == 0 && ...
7 years, 9 months ago (2013-03-11 16:42:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12658003/8001
7 years, 9 months ago (2013-03-11 16:42:44 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 20:12:38 UTC) #8
Message was sent while issue was closed.
Change committed as 187356

Powered by Google App Engine
This is Rietveld 408576698