Issue 12656004: Removes now-useless DCHECKs as per discussion with atwilson@.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12656004: Removes now-useless DCHECKs as per discussion with atwilson@. (Closed)

Created:
7 years, 9 months ago by macourteau

Modified:
7 years, 9 months ago

Reviewers:
Andrew T Wilson (Slow), Peter Kasting

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, tapted

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Removes now-useless DCHECKs as per discussion with atwilson@. The WebDataService initialization is now delayed on the main browser thread (per tapted@'s patch). The WebDataService needs to be initialized during the import process if either import_search_engine or import_bookmarks_from_file are specified in the master_preferences file. BUG=180306 TEST=The presence of either of the import_search_engine and import_bookmarks_from_file flags (in master_preferences) no longer crash in Debug builds (on first run after a clean install). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187413

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/browser/webdata/web_data_service.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/webdata/web_database_service_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

macourteau

(adding atwilson@ to the reviewers list, and tapted@ to the cc list)

7 years, 9 months ago (2013-03-11 18:20:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/12656004/1

7 years, 9 months ago (2013-03-11 20:37:26 UTC) #4

Message was sent while issue was closed.

Change committed as 187413

Expand Messages | Collapse Messages