Make drover produce git friendly titles.

drover.py

Index: drover.py
diff --git a/drover.py b/drover.py
index b806eda30da310f926ac63b4010b6403326f605b..ce98da4a34ef650ebf0d086263df7d2c7b6d41a0 100755
--- a/drover.py
+++ b/drover.py
@@ -595,10 +595,17 @@ def drover(options, args):
 
   filename = str(revision)+".txt"
   out = open(filename,"w")
-  out.write(action +" " + str(revision) + "\n")
-  for line in getRevisionLog(url, revision).splitlines():
+  drover_title = '%s %s' % (action, revision)
+  revision_log = getRevisionLog(url, revision).splitlines()
+  if revision_log:
+    commit_title = revision_log[0]
+    if len(commit_title) > 30:

[M-A Ruel, 2013/03/11 13:10:27]

Isn't 30 a tad short?

[Isaac (away), 2013/03/11 17:36:11]

In the chromium-dev thread "Git-friendly CL Descriptions" enne@ suggested
limiting titles to 50 chars.  Adrienne: What's the reasoning behind the shorter
limit for titles?

[Isaac (away), 2013/03/11 18:45:04]

OK after talking to enne@, it looks like 68 char length limit is sufficient.  So
changed to calculating the max title length for that.

+      commit_title = commit_title[:27] + '...'

[M-A Ruel, 2013/03/11 13:10:27]

I always use '…' instead. So you can use commit_title[:29] and it also enforces
unicode works in a 2-for-1 trick.

Add at the top of the file:
# coding: utf-8

The idea: python knows the file is encoded as utf-8 because of the top coding
comment, so it uses the litteral utf-8 form in the str '…' instead of the
unicode string u'…', which you don't want. So it just works.

[Isaac (away), 2013/03/11 17:36:11]

Are there other examples of commits which use unicode characters?  I'd rather
this CL not be a pioneer in that regard.

[M-A Ruel, 2013/03/11 17:45:39]

(M=79420) ~/src/b/depot_tools> git gs "…"
rietveld.py:246:    tail = '…\n(message too large)'
third_party/upload.py:2305:    title = title[:99] + '…'

upload.py does it for title, rietveld.py does it for comments.
rietveld.py asserts the CL description is utf-8 when committing through the CQ.

While git-cl nor gcl currently enforce utf-8 encoding, enforcing utf-8 would be
something I'd like.

Anyhow, I'm not strongly attached to it.

+    drover_title += ' "%s"' % commit_title
+  out.write(drover_title + '\n\n')
+  for line in revision_log:
     out.write('> %s\n' % line)
-  if (author):
+  if author:
     out.write("\nTBR=" + author)
   out.close()