Make drover produce git friendly titles.

Make drover produce git friendly titles.

Put a blank line in between drover title and message.
Also include snippet of commit title in drover title,
but keep total title line length below 50 chars.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=187329

[laforge, 2013-03-11 06:06:28]

On 2013/03/11 06:01:05, Isaac wrote:

LGTM

[M-A Ruel, 2013-03-11 13:10:27]

lgtm anyhow, with optional comments.

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode602
drover.py:602: if len(commit_title) > 30:
Isn't 30 a tad short?

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode603
drover.py:603: commit_title = commit_title[:27] + '...'
I always use '…' instead. So you can use commit_title[:29] and it also enforces
unicode works in a 2-for-1 trick.

Add at the top of the file:
# coding: utf-8

The idea: python knows the file is encoded as utf-8 because of the top coding
comment, so it uses the litteral utf-8 form in the str '…' instead of the
unicode string u'…', which you don't want. So it just works.

[enne (OOO), 2013-03-11 16:43:47]

Thanks for this!

[Isaac (away), 2013-03-11 17:36:11]

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode602
drover.py:602: if len(commit_title) > 30:
On 2013/03/11 13:10:27, Marc-Antoine Ruel wrote:
> Isn't 30 a tad short?

In the chromium-dev thread "Git-friendly CL Descriptions" enne@ suggested
limiting titles to 50 chars.  Adrienne: What's the reasoning behind the shorter
limit for titles?

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode603
drover.py:603: commit_title = commit_title[:27] + '...'
On 2013/03/11 13:10:27, Marc-Antoine Ruel wrote:
> I always use '…' instead. So you can use commit_title[:29] and it also
enforces
> unicode works in a 2-for-1 trick.
> 
> Add at the top of the file:
> # coding: utf-8
> 
> The idea: python knows the file is encoded as utf-8 because of the top coding
> comment, so it uses the litteral utf-8 form in the str '…' instead of the
> unicode string u'…', which you don't want. So it just works.

Are there other examples of commits which use unicode characters?  I'd rather
this CL not be a pioneer in that regard.

[M-A Ruel, 2013-03-11 17:45:39]

Just need to decide the cut off, in theory you'd want to cut it so that the
total line length is exactly 72 so I'd probably prefer to have the code
calculate the cutoff based on a max line length of 72.

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode603
drover.py:603: commit_title = commit_title[:27] + '...'
On 2013/03/11 17:36:11, Isaac wrote:
> On 2013/03/11 13:10:27, Marc-Antoine Ruel wrote:
> > I always use '…' instead. So you can use commit_title[:29] and it also
> enforces
> > unicode works in a 2-for-1 trick.
> > 
> > Add at the top of the file:
> > # coding: utf-8
> > 
> > The idea: python knows the file is encoded as utf-8 because of the top
coding
> > comment, so it uses the litteral utf-8 form in the str '…' instead of the
> > unicode string u'…', which you don't want. So it just works.
> 
> Are there other examples of commits which use unicode characters?  I'd rather
> this CL not be a pioneer in that regard.

(M=79420) ~/src/b/depot_tools> git gs "…"
rietveld.py:246:    tail = '…\n(message too large)'
third_party/upload.py:2305:    title = title[:99] + '…'

upload.py does it for title, rietveld.py does it for comments.
rietveld.py asserts the CL description is utf-8 when committing through the CQ.

While git-cl nor gcl currently enforce utf-8 encoding, enforcing utf-8 would be
something I'd like.

Anyhow, I'm not strongly attached to it.

[Isaac (away), 2013-03-11 18:45:04]

Prefer to add unicode characters in a different CL.

CQing...

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py
File drover.py (right):

https://chromiumcodereview.appspot.com/12656003/diff/1/drover.py#newcode602
drover.py:602: if len(commit_title) > 30:
OK after talking to enne@, it looks like 68 char length limit is sufficient.  So
changed to calculating the max title length for that.

[commit-bot: I haz the power, 2013-03-11 18:46:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12656003/9001

[commit-bot: I haz the power, 2013-03-11 18:48:54]

Change committed as 187329

[hmoshe2000_gmail.com, 2016-02-05 18:54:08]

فوفة

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.