Remove failure for bad mmap address hints.

tests/syscalls/mem_test.cc

 // Copyright 2010 The Native Client Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can
 // be found in the LICENSE file.
 
 #include <errno.h>
 #include <sys/mman.h>
 
 #include <cstdlib>
 #include <cstring>
 
@@ skipping 36 matching lines @@
                         k64Kbytes,
                         PROT_READ,
                         MAP_PRIVATE,
                         kBadFiledesc,
                         0);
   EXPECT(MAP_FAILED == mmap_ptr);
   EXPECT(EBADF == errno);
   END_TEST();
 }
 
+// Verify that mmap does not fail if a bad hint address is passed, but
+// |MMAP_FIXED| is not specified.
+int TestMmapBadHint() {
+  START_TEST("TestMmapBadHint");
+  void* bad_hint = (void *) 0x123;
+  void* mmap_ptr = mmap(bad_hint,
+                        k64Kbytes,
+                        PROT_READ,
+                        MAP_PRIVATE | MAP_ANONYMOUS,
+                        kAnonymousFiledesc,
+                        0);
+  EXPECT(MAP_FAILED != mmap_ptr);
+  EXPECT(mmap_ptr != bad_hint);
+  EXPECT(munmap(mmap_ptr, k64Kbytes) == 0);
+  END_TEST();
+}
+

[Mark Seaborn, 2015/07/30 15:20:14]

Nit: be consistent about whether there's 1 or 2 empty lines between top-level
definitions

[Sean Klein, 2015/07/30 16:04:29]

Done.

+
 // Test mmap() and munmap(), since these often to go together.  Tries to mmap
 // a 64 Kb region of memory and then tests to make sure that the pages have all
 // been 0-filled.
 int TestMmapMunmap() {
   START_TEST("TestMmapMunmap");
   void* mmap_ptr = mmap(NULL,
                         k64Kbytes,
                         PROT_READ,
                         MAP_PRIVATE | MAP_ANONYMOUS,
                         kAnonymousFiledesc,
@@ skipping 84 matching lines @@
   END_TEST();
 }
 }  // namespace
 
 // Run through the complete sequence of memory tests.  Sets the exit code to
 // the number of failed tests.  Exit code 0 means all passed.
 int main() {
   int fail_count = 0;
   fail_count += TestZeroLengthRegion();
   fail_count += TestBadFiledesc();
+  fail_count += TestMmapBadHint();
   fail_count += TestMmapMunmap();
   fail_count += TestMunmapText();
   fail_count += TestMmapNULL();
   fail_count += TestMmap32k();
   fail_count += TestMmapNonPageAligned();
   return fail_count;
 }