Regularize storage monitor creation in Windows.

Regularize storage monitor creation in Windows.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194784

[Greg Billock, 2013-04-16 22:38:46]

Ready for review.

akalin, I identified what I think the comment was that headed me wrong. If the
test I added is duplicative, I'm happy to remove. It proves a common usage of
the class that was giving me trouble with the ToastCrasher, but if existing
tests essentially do this through the SequencedWorkerPoolOwner, then it may not
be doing anything new.

[vandebo (ex-Chrome), 2013-04-16 23:27:22]

Media Galleries changes LGTM

[akalin, 2013-04-18 01:20:31]

I'm a bit overloaded -- kicking over to jar (whose approval you'd need for base/
anyway.)

[jar (doing other things), 2013-04-18 01:56:23]

Thanks for chatting about this.

LGTM

https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
File base/threading/sequenced_worker_pool_unittest.cc (right):

https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
base/threading/sequenced_worker_pool_unittest.cc:784: // closures have been
deleted deleted by looking at the refcount of the
nit: "deleted deleted"   since you're cleaning up here ;-)

[commit-bot: I haz the power, 2013-04-18 02:01:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/12647013/42001

[commit-bot: I haz the power, 2013-04-18 02:01:45]

Presubmit check for 12647013-42001 failed and returned exit status 1.

INFO:root:Found 5 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/chrome_browser_main_win.cc
    chrome/browser/chrome_browser_main_win.h

[Greg Billock, 2013-04-18 02:02:04]

https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
File base/threading/sequenced_worker_pool_unittest.cc (right):

https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
base/threading/sequenced_worker_pool_unittest.cc:784: // closures have been
deleted deleted by looking at the refcount of the
On 2013/04/18 01:56:23, jar wrote:
> nit: "deleted deleted"   since you're cleaning up here ;-)

Done.

[Greg Billock, 2013-04-18 02:03:32]

On 2013/04/18 02:02:04, Greg Billock wrote:
>
https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
> File base/threading/sequenced_worker_pool_unittest.cc (right):
> 
>
https://codereview.chromium.org/12647013/diff/37002/base/threading/sequenced_...
> base/threading/sequenced_worker_pool_unittest.cc:784: // closures have been
> deleted deleted by looking at the refcount of the
> On 2013/04/18 01:56:23, jar wrote:
> > nit: "deleted deleted"   since you're cleaning up here ;-)
> 
> Done.

+thestig for chrome/browser/OWNERS

[Lei Zhang, 2013-04-18 02:15:37]

lgtm

[commit-bot: I haz the power, 2013-04-18 02:16:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/12647013/42001

[commit-bot: I haz the power, 2013-04-18 02:23:18]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-18 02:34:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/12647013/56001

[commit-bot: I haz the power, 2013-04-18 05:41:24]

Change committed as 194784