bluetooth: Return specific message if Bluetooth Adapter is off

bluetooth: Return specific message if Bluetooth Adapter is off

Per discussion in:

https://github.com/WebBluetoothCG/web-bluetooth/issues/127#issuecomment-119698067

an off bluetooth adapter now rejects with NotFoundError. Also adds necessary
fake adapters.

Three-way patch to add 'BluetoothAdapter is off' error message:
 [1] Add constant to public WebBluetoothError. (http://crrev.com/1267843005)
 [2] This patch.
 [3] Add tests for Not present adapter and Off adapter. (http://crrev.com/1261993012)

Drive-by fix: Inherits form |BaseAdapter| -> |EmptyAdapter|

BUG=515573
Committed: https://crrev.com/bd3d4d8a10336091ecbc30f250ce40be5ebdbd57
Cr-Commit-Position: refs/heads/master@{#342485}

[ortuno, 2015-08-03 23:02:09]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-08-03 23:02:09]

@jyasskin: PTAL

[Jeffrey Yasskin, 2015-08-05 17:13:14]

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:305: Send(new
BluetoothMsg_RequestDeviceError(
Every Send needs to be matched to a request_device_sessions_.erase() call, or
come before the .insert().

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:309: if
(!adapter_->IsPowered()) {
This one isn't going to happen once we have the real dialog wired up. The dialog
will present a message asking the user to turn on the adapter, and if the user
chooses not to, they'll cancel the dialog. That should look to the code the same
as if they cancelled for any other reason.

At most, I think we should have a TODO here, to wire IsPowered() and
BluetoothAdapter::Observer::PoweredChanged to the dialog.

[ortuno, 2015-08-05 18:01:53]

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:305: Send(new
BluetoothMsg_RequestDeviceError(
On 2015/08/05 at 17:13:14, Jeffrey Yasskin wrote:
> Every Send needs to be matched to a request_device_sessions_.erase() call, or
come before the .insert().

Done.

https://codereview.chromium.org/1264323002/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:309: if
(!adapter_->IsPowered()) {
On 2015/08/05 at 17:13:13, Jeffrey Yasskin wrote:
> This one isn't going to happen once we have the real dialog wired up. The
dialog will present a message asking the user to turn on the adapter, and if the
user chooses not to, they'll cancel the dialog. That should look to the code the
same as if they cancelled for any other reason.
> 
> At most, I think we should have a TODO here, to wire IsPowered() and
BluetoothAdapter::Observer::PoweredChanged to the dialog.

True. But the dialog is gonna take a couple of releases to get wired up on all
platforms so I still think this log/histogram/message is useful. I'll add a TODO
for wiring it up to the dialog though.

Also this just made me realize that we don't handle the case where a user turns
off bluetooth midway. So for example if you connect to a device turn off
bluetooth and then call getPrimaryService nothing happens, no errors, no logs,
nothing.

[Jeffrey Yasskin, 2015-08-05 20:49:43]

Ok, lgtm.

[ortuno, 2015-08-05 20:58:58]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-08-05 20:58:59]

@scheib: PTAL

[scheib, 2015-08-05 21:36:04]

LGTM

[ortuno, 2015-08-06 20:38:04]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-08-06 20:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1264323002/#ps80001
(title: "Add issue to TODO")

[commit-bot: I haz the power, 2015-08-06 20:39:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-06 20:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 20:51:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2015-08-06 20:55:57]

ortuno@chromium.org changed reviewers:
+ asvitkine@chromium.org

[ortuno, 2015-08-06 20:55:57]

@asvitkine: PTAL at histograms.xml. No new histograms just added two values to
an enum.

[Alexei Svitkine (slow), 2015-08-06 20:57:04]

lgtm

[ortuno, 2015-08-06 21:04:36]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-08-06 21:05:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-06 22:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 22:41:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ortuno, 2015-08-07 17:07:58]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-08-07 17:08:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-07 18:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 18:28:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ortuno, 2015-08-07 19:13:34]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-08-07 19:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-07 21:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 21:31:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ortuno, 2015-08-07 21:47:00]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-08-07 21:48:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-07 23:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 23:08:33]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2015-08-07 23:09:10]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-08-07 23:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264323002/80001

[commit-bot: I haz the power, 2015-08-08 00:01:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-08 00:02:52]

Patchset 5 (id:??) landed as
https://crrev.com/bd3d4d8a10336091ecbc30f250ce40be5ebdbd57
Cr-Commit-Position: refs/heads/master@{#342485}