Issue 12640006: [android] Improve reverse forwarder error handling

Issue 12640006: [android] Improve reverse forwarder error handling (Closed)

Created:
7 years, 9 months ago by Sami

Modified:
7 years, 9 months ago

Reviewers:
Tom Hudson, bulach

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Improve reverse forwarder error handling Tell the user if they are trying to use the reverse ADB forwarder without having first built the requisite host_forwarder tool. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187033

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move check to forwarder.py #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	build/android/pylib/forwarder.py	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, one suggestion below to help even more users :) https://codereview.chromium.org/12640006/diff/1/build/android/adb_reverse_forwarder.py File build/android/adb_reverse_forwarder.py (right): https://codereview.chromium.org/12640006/diff/1/build/android/adb_reverse_forwarder.py#newcode67 ...

7 years, 9 months ago (2013-03-08 15:15:33 UTC) #2

Sami

On 2013/03/08 15:15:33, bulach wrote: > maybe push this down to forwarder.py Run itself? Excellent ...

7 years, 9 months ago (2013-03-08 16:10:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/12640006/4001

7 years, 9 months ago (2013-03-08 16:11:00 UTC) #4

Message was sent while issue was closed.

Change committed as 187033

Expand Messages | Collapse Messages