Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12638030: Make AudioDecoderConfig copyable. (Closed)

Created:
7 years, 9 months ago by xhwang
Modified:
7 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Make AudioDecoderConfig copyable. This is a follow-up CL of r187702. BUG=177543 TEST=All tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188072

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -102 lines) Patch
M media/base/audio_decoder_config.h View 4 chunks +10 lines, -11 lines 0 comments Download
M media/base/audio_decoder_config.cc View 3 chunks +1 line, -21 lines 0 comments Download
M media/base/decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mock_filters.h View 2 chunks +1 line, -7 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/crypto/aes_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M media/crypto/aes_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream.cc View 1 6 chunks +10 lines, -14 lines 0 comments Download
M media/webm/webm_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/crypto/ppapi_decryptor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/media/crypto/ppapi_decryptor.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
xhwang
PTAL
7 years, 9 months ago (2013-03-12 21:54:41 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
7 years, 9 months ago (2013-03-12 22:29:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/13002
7 years, 9 months ago (2013-03-13 00:19:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=14806
7 years, 9 months ago (2013-03-13 00:36:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/13002
7 years, 9 months ago (2013-03-13 01:00:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=90540
7 years, 9 months ago (2013-03-13 01:17:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/13002
7 years, 9 months ago (2013-03-13 02:59:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=90582
7 years, 9 months ago (2013-03-13 03:14:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/13002
7 years, 9 months ago (2013-03-13 15:35:10 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromedriver2_unittests, components_unittests, ...
7 years, 9 months ago (2013-03-13 15:49:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/13002
7 years, 9 months ago (2013-03-13 20:43:41 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-13 22:04:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/12638030/64001
7 years, 9 months ago (2013-03-14 01:05:21 UTC) #13
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 14:55:01 UTC) #14
Message was sent while issue was closed. 
Change committed as 188072

Powered by Google App Engine
This is Rietveld 408576698