Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 12637025: DateField cache should check the ExternalOperand instead of ExternalReference on X64 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3040 matching lines...) Expand 10 before | Expand all | Expand 10 after
3051 __ JumpIfSmi(object, &not_date_object); 3051 __ JumpIfSmi(object, &not_date_object);
3052 __ CmpObjectType(object, JS_DATE_TYPE, scratch); 3052 __ CmpObjectType(object, JS_DATE_TYPE, scratch);
3053 __ j(not_equal, &not_date_object); 3053 __ j(not_equal, &not_date_object);
3054 3054
3055 if (index->value() == 0) { 3055 if (index->value() == 0) {
3056 __ movq(result, FieldOperand(object, JSDate::kValueOffset)); 3056 __ movq(result, FieldOperand(object, JSDate::kValueOffset));
3057 __ jmp(&done); 3057 __ jmp(&done);
3058 } else { 3058 } else {
3059 if (index->value() < JSDate::kFirstUncachedField) { 3059 if (index->value() < JSDate::kFirstUncachedField) {
3060 ExternalReference stamp = ExternalReference::date_cache_stamp(isolate()); 3060 ExternalReference stamp = ExternalReference::date_cache_stamp(isolate());
3061 __ movq(scratch, stamp); 3061 Operand stamp_operand = __ ExternalOperand(stamp);
3062 __ movq(scratch, stamp_operand);
3062 __ cmpq(scratch, FieldOperand(object, JSDate::kCacheStampOffset)); 3063 __ cmpq(scratch, FieldOperand(object, JSDate::kCacheStampOffset));
3063 __ j(not_equal, &runtime, Label::kNear); 3064 __ j(not_equal, &runtime, Label::kNear);
3064 __ movq(result, FieldOperand(object, JSDate::kValueOffset + 3065 __ movq(result, FieldOperand(object, JSDate::kValueOffset +
3065 kPointerSize * index->value())); 3066 kPointerSize * index->value()));
3066 __ jmp(&done); 3067 __ jmp(&done);
3067 } 3068 }
3068 __ bind(&runtime); 3069 __ bind(&runtime);
3069 __ PrepareCallCFunction(2); 3070 __ PrepareCallCFunction(2);
3070 #ifdef _WIN64 3071 #ifdef _WIN64
3071 __ movq(rcx, object); 3072 __ movq(rcx, object);
(...skipping 1500 matching lines...) Expand 10 before | Expand all | Expand 10 after
4572 *context_length = 0; 4573 *context_length = 0;
4573 return previous_; 4574 return previous_;
4574 } 4575 }
4575 4576
4576 4577
4577 #undef __ 4578 #undef __
4578 4579
4579 } } // namespace v8::internal 4580 } } // namespace v8::internal
4580 4581
4581 #endif // V8_TARGET_ARCH_X64 4582 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698