chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java - Issue 1263573011: Let client specify content description for custom action button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 1263573011: Let client specify content description for custom action button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix corresponding test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

index fdfad02ea1fd0fbc7f97f992982cbc3dc5ae95f0..80ce2c43057930a27a16bd0db0f7aae2e9707a9f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

@@ -619,11 +619,13 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe

/**

* Adds a custom action button to the {@link Toolbar} if it is supported.

- * @param drawable The {@link Drawable} to use as the background for the button.

- * @param listener The {@link OnClickListener} to use for clicks to the button.

+ * @param drawable The {@link Drawable} to use as the background for the button.

+ * @param description The content description for the custom action button.

+ * @param listener The {@link OnClickListener} to use for clicks to the button.

- public void addCustomActionButton(Drawable drawable, OnClickListener listener) {

- mToolbar.addCustomActionButton(drawable, listener);

+ public void addCustomActionButton(Drawable drawable, String description,

+ OnClickListener listener) {

+ mToolbar.addCustomActionButton(drawable, description, listener);

}

/**