chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Renamed button_close_2* to close_2* Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/renderer/resources/plugin_placeholders.css » ('j') | chrome/renderer/resources/plugin_placeholders.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index d993e091e0c98418a98099747590ca9d1322f0f4..0a5ad263fd93693e0d3e068d7a3a72c0b0267f33 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -181,11 +181,11 @@ PopupHeaderView::PopupHeaderView(views::ButtonListener* close_button_listener)

new views::ImageButton(close_button_listener);

ResourceBundle& rb = ResourceBundle::GetSharedInstance();

close_button->SetImage(views::CustomButton::STATE_NORMAL,

- rb.GetImageNamed(IDR_CLOSE_BAR).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2).ToImageSkia());

close_button->SetImage(views::CustomButton::STATE_HOVERED,

- rb.GetImageNamed(IDR_CLOSE_BAR_H).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2_H).ToImageSkia());

close_button->SetImage(views::CustomButton::STATE_PRESSED,

- rb.GetImageNamed(IDR_CLOSE_BAR_P).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2_P).ToImageSkia());

layout->AddView(close_button, 1, 1, views::GridLayout::TRAILING,

views::GridLayout::LEADING);