Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 12634019: NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | chromeos/network/network_state_handler_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index be8696eac730971d435cdc96334803779303b075..e623b0ea2b7b757c623a09c766028bfda0388bf7 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -433,20 +433,16 @@ void NetworkStateHandler::UpdateNetworkServiceProperty(
detail += " = " + vstr;
network_event_log::AddEntry(kLogModule, "NetworkPropertyUpdated", detail);
- if (network->connection_state() != prev_connection_state)
+ if (network->connection_state() != prev_connection_state) {
OnNetworkConnectionStateChanged(network);
- NetworkPropertiesUpdated(network);
-}
+ }
+ else if (network->path() == default_network_path_ &&
+ key != flimflam::kSignalStrengthProperty) {
+ // WiFi signal strength updates are too noisy, so don't
+ // trigger default network updates for those changes.
+ OnDefaultNetworkChanged();
+ }
-void NetworkStateHandler::UpdateNetworkServiceIPAddress(
- const std::string& service_path,
- const std::string& ip_address) {
- NetworkState* network = GetModifiableNetworkState(service_path);
- if (!network)
- return;
- std::string detail = network->name() + ".IPAddress = " + ip_address;
- network_event_log::AddEntry(kLogModule, "NetworkIPChanged", detail);
- network->set_ip_address(ip_address);
NetworkPropertiesUpdated(network);
}
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | chromeos/network/network_state_handler_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698