Issue 12631017: Remove notifications when apps and OTR Profiles are removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12631017: Remove notifications when apps and OTR Profiles are removed. (Closed)

Created:
7 years, 9 months ago by dewittj

Modified:
7 years, 9 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove notifications when apps and OTR Profiles are removed. This patch modifies DesktopNotificationService so that it doesn't listen for the NOTIFICATION_PROFILE_DESTROYED or NOTIFICATION_APP_UNLOADED messages, instead the NotificationUIManagerImpl now does that directly. Additionally, MessageCenterNotificationManager used IsSameProfile when matching profiles to clear, but that should have been just "==", since we don't want closing an incognito profile to also close all notifications for the parent profile. BUG=196408 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188302

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -57 lines)			Patch
M	chrome/browser/notifications/desktop_notification_service.h	View	4 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View	3 chunks	+1 line, -44 lines	0 comments	Download
M	chrome/browser/notifications/message_center_notification_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager_impl.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/12631017/1

7 years, 9 months ago (2013-03-15 00:40:57 UTC) #3

Message was sent while issue was closed.

Change committed as 188302

Expand Messages | Collapse Messages