chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments + add tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/child_frame.html » ('j') | chrome/test/data/extensions/platform_apps/web_view/shim/child_frame.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index 12e78096b294ecf695169f583fe14cacb2660d6f..7955d60e273b69804b29f8c7c7a2d9fe8c12d502 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -1089,6 +1089,10 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestNavigateAfterResize) {

TestHelper("testNavigateAfterResize", "web_view/shim", NO_TEST_SERVER);

}

+IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestNestedSubframes) {

+ TestHelper("testNestedSubframes", "web_view/shim", NO_TEST_SERVER);

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestRemoveSrcAttribute) {

TestHelper("testRemoveSrcAttribute", "web_view/shim", NO_TEST_SERVER);

}