Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12623031: Pass the overdraw value to the browser w/ frame (Closed)

Created:
7 years, 9 months ago by David Trainor- moved to gerrit
Modified:
7 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Pass the overdraw value to the browser w/ frame We rely on the overdraw value to position some content, but there is usually one frame before the value we sent to the renderer comes back. Need to have the renderer pass the value back to us and rely on that when doing calculations in the browser process. BUG=221995, 222070 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190629

Patch Set 1 #

Total comments: 2

Patch Set 2 : Where did gitmodules come from? #

Patch Set 3 : address nits #

Patch Set 4 : Interface for test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M cc/output/compositor_frame_metadata.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/compositor_frame_metadata.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/common/cc_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
David Trainor- moved to gerrit
PTAL tedchoc: content/browser/android and content/public/android jamesr: cc/ aelias: content/browser/ palmer: content/common/ avi: content/port/ Thanks!
7 years, 9 months ago (2013-03-23 00:29:59 UTC) #1
jamesr
cc -> aelias
7 years, 9 months ago (2013-03-23 00:37:40 UTC) #2
Avi (use Gerrit)
I'll stamp lgtm contingent on a review from an android expert.
7 years, 9 months ago (2013-03-23 01:46:34 UTC) #3
aelias_OOO_until_Jul13
lgtm
7 years, 9 months ago (2013-03-24 00:53:46 UTC) #4
Ted C
lgtm https://codereview.chromium.org/12623031/diff/1/cc/output/compositor_frame_metadata.cc File cc/output/compositor_frame_metadata.cc (right): https://codereview.chromium.org/12623031/diff/1/cc/output/compositor_frame_metadata.cc#newcode14 cc/output/compositor_frame_metadata.cc:14: overdraw_bottom_height(0) { Should this (and maybe the others) ...
7 years, 9 months ago (2013-03-24 15:37:46 UTC) #5
palmer
IPC security LGTM
7 years, 9 months ago (2013-03-25 22:44:13 UTC) #6
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/12623031/diff/1/cc/output/compositor_frame_metadata.cc File cc/output/compositor_frame_metadata.cc (right): https://chromiumcodereview.appspot.com/12623031/diff/1/cc/output/compositor_frame_metadata.cc#newcode14 cc/output/compositor_frame_metadata.cc:14: overdraw_bottom_height(0) { On 2013/03/24 15:37:46, Ted C wrote: > ...
7 years, 9 months ago (2013-03-26 04:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/12623031/23001
7 years, 9 months ago (2013-03-26 05:08:55 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-26 05:22:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/12623031/12003
7 years, 9 months ago (2013-03-26 05:22:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/12623031/12003
7 years, 9 months ago (2013-03-26 06:56:28 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 10:00:03 UTC) #12
Message was sent while issue was closed. 
Change committed as 190629

Powered by Google App Engine
This is Rietveld 408576698