cc: Chromify TimeSource, DelayBasedTimeSource and test

cc: Chromify TimeSource, DelayBasedTimeSource and test

R=danakj@chromium.org
BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189275

[enne (OOO), 2013-03-19 21:05:13]

Depends on https://codereview.chromium.org/12922002/.

[commit-bot: I haz the power, 2013-03-20 04:07:06]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jamesr, 2013-03-20 04:41:24]

lgtm

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
File cc/scheduler/delay_based_time_source.cc (right):

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
cc/scheduler/delay_based_time_source.cc:22: static const float
kDoubleTickThreshold = 0.25;
well this isn't a double at all. can you update the name (and add f) or change
it back?

[enne (OOO), 2013-03-20 04:51:55]

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
File cc/scheduler/delay_based_time_source.cc (right):

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
cc/scheduler/delay_based_time_source.cc:22: static const float
kDoubleTickThreshold = 0.25;
On 2013/03/20 04:41:24, jamesr wrote:
> well this isn't a double at all. can you update the name (and add f) or change
> it back?

I am not 100% sure on this, but I think "double" here is not referring to the
type.  See line 217 where it talks about "double ticks".

[jamesr, 2013-03-20 04:59:29]

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
File cc/scheduler/delay_based_time_source.cc (right):

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
cc/scheduler/delay_based_time_source.cc:22: static const float
kDoubleTickThreshold = 0.25;
On 2013/03/20 04:51:55, enne wrote:
> On 2013/03/20 04:41:24, jamesr wrote:
> > well this isn't a double at all. can you update the name (and add f) or
change
> > it back?
> 
> I am not 100% sure on this, but I think "double" here is not referring to the
> type.  See line 217 where it talks about "double ticks".

Ooh, ok. 'f' it up then

[enne (OOO), 2013-03-20 05:06:20]

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
File cc/scheduler/delay_based_time_source.cc (right):

https://chromiumcodereview.appspot.com/12623026/diff/1/cc/scheduler/delay_bas...
cc/scheduler/delay_based_time_source.cc:22: static const float
kDoubleTickThreshold = 0.25;
On 2013/03/20 04:59:29, jamesr wrote:
> On 2013/03/20 04:51:55, enne wrote:
> > On 2013/03/20 04:41:24, jamesr wrote:
> > > well this isn't a double at all. can you update the name (and add f) or
> change
> > > it back?
> > 
> > I am not 100% sure on this, but I think "double" here is not referring to
the
> > type.  See line 217 where it talks about "double ticks".
> 
> Ooh, ok. 'f' it up then

Done.

[commit-bot: I haz the power, 2013-03-20 05:06:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12623026/8001

[commit-bot: I haz the power, 2013-03-20 05:26:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-20 05:49:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12623026/9017

[enne (OOO), 2013-03-20 06:21:33]

Apparently, InSecondsF returns a double.  Changed everything back.

[commit-bot: I haz the power, 2013-03-20 14:00:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12623026/9017

[commit-bot: I haz the power, 2013-03-20 14:53:28]

Change committed as 189275