Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: build/isolate.gypi

Issue 12623013: Change test_isolation_mode default from noop to check (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included into a target to provide a rule 5 # This file is meant to be included into a target to provide a rule
6 # to "build" .isolate files into a .isolated file. 6 # to "build" .isolate files into a .isolated file.
7 # 7 #
8 # To use this, create a gyp target with the following form: 8 # To use this, create a gyp target with the following form:
9 # 'conditions': [ 9 # 'conditions': [
10 # ['test_isolation_mode != "noop"', { 10 # ['test_isolation_mode != "noop"', {
(...skipping 22 matching lines...) Expand all
33 # 33 #
34 # The generated .isolated file will be: 34 # The generated .isolated file will be:
35 # <(PRODUCT_DIR)/foo_test.isolated 35 # <(PRODUCT_DIR)/foo_test.isolated
36 36
37 { 37 {
38 'rules': [ 38 'rules': [
39 { 39 {
40 'rule_name': 'isolate', 40 'rule_name': 'isolate',
41 'extension': 'isolate', 41 'extension': 'isolate',
42 'inputs': [ 42 'inputs': [
43 '<(RULE_INPUT_PATH)',
44 # Disable file tracking by the build driver for now. This means the 43 # Disable file tracking by the build driver for now. This means the
45 # project must have the proper build-time dependency for their runtime 44 # project must have the proper build-time dependency for their runtime
46 # dependency. This improves the runtime of the build driver since it 45 # dependency. This improves the runtime of the build driver since it
47 # doesn't have to stat() all these files. 46 # doesn't have to stat() all these files.
48 # 47 #
49 # More importantly, it means that even if a isolate_dependency_tracked 48 # More importantly, it means that even if a isolate_dependency_tracked
50 # file is missing, for example if a file was deleted and the .isolate 49 # file is missing, for example if a file was deleted and the .isolate
51 # file was not updated, that won't break the build, especially in the 50 # file was not updated, that won't break the build, especially in the
52 # case where foo_tests_run is not built! This should be reenabled once 51 # case where foo_tests_run is not built! This should be reenabled once
53 # the switch-over to running tests on Swarm is completed. 52 # the switch-over to running tests on Swarm is completed.
54 #'<@(isolate_dependency_tracked)', 53 #'<@(isolate_dependency_tracked)',
55 ], 54 ],
56 'outputs': [ 55 'outputs': [
57 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated', 56 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated',
58 ], 57 ],
59 'action': [ 58 'action': [
60 'python', 59 'python',
61 '<(DEPTH)/tools/swarm_client/isolate.py', 60 '<(DEPTH)/tools/swarm_client/isolate.py',
62 '<(test_isolation_mode)', 61 '<(test_isolation_mode)',
62 '--outdir', '<(test_isolation_outdir)',
63 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)', 63 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
64 '--variable', 'OS', '<(OS)', 64 '--variable', 'OS', '<(OS)',
65 '--variable', 'chromeos', '<(chromeos)', 65 '--variable', 'chromeos', '<(chromeos)',
66 '--result', '<@(_outputs)', 66 '--result', '<@(_outputs)',
67 '--isolate', '<(RULE_INPUT_PATH)', 67 '--isolate', '<(RULE_INPUT_PATH)',
68 ], 68 ],
69 'conditions': [ 69 'conditions': [
70 ["test_isolation_outdir!=''", { 70 ["test_isolation_outdir!=''", {
71 'action': [ 71 'action': [
72 '--outdir', '<(PRODUCT_DIR)/<(test_isolation_outdir)', 72 '--outdir', '<(PRODUCT_DIR)/<(test_isolation_outdir)',
73 ], 73 ],
74 }], 74 }],
75 ['test_isolation_fail_on_missing == 0', {
76 'action': ['--ignore_broken_items']
77 },
78 ],
75 ], 79 ],
76
77 'msvs_cygwin_shell': 0, 80 'msvs_cygwin_shell': 0,
78 }, 81 },
79 ], 82 ],
80 } 83 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698