Issue 12623012: Adding a check to not show sync promo for incognito profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12623012: Adding a check to not show sync promo for incognito profiles (Closed)

Created:
7 years, 9 months ago by jwd

Modified:
7 years, 9 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding a check to not show sync promo for incognito profiles. This prevents the sync promo from being shown when chrome is launched into incognito. There may be an underlying reason why this was happening that isn't being addressed by this change. BUG=180183 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187700

Patch Set 1 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/12623012/2001

7 years, 9 months ago (2013-03-12 18:24:52 UTC) #2

Message was sent while issue was closed.

Change committed as 187700

Expand Messages | Collapse Messages