Make gclient fetch git repos recursively. This is needed when adding a git repo through DEPS. If th…

Make gclient fetch git repos recursively. This is needed when adding a git repo through DEPS. If that repo has submodules, we need to fetch them or else the repo won't be complete.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189026

[jam, 2013-03-18 17:49:15]

Stefan: I believe recurseSubmodules is the flag that you mentioned over chat,
but I can't be sure since I don't have a log.

[szager1, 2013-03-18 22:04:46]

https://codereview.chromium.org/12620024/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12620024/diff/1/gclient_scm.py#newcode212
gclient_scm.py:212: gclient_utils.CheckCallAndFilter(cmd3, **kwargs)
I think this should be outside the try/except clause.  If it fails, the error
should be surfaced.  Unlike the other commands, if it fails, you could wind up
with a bad state in your checkout.

[jam, 2013-03-18 22:10:24]

https://codereview.chromium.org/12620024/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12620024/diff/1/gclient_scm.py#newcode212
gclient_scm.py:212: gclient_utils.CheckCallAndFilter(cmd3, **kwargs)
On 2013/03/18 22:04:46, szager1 wrote:
> I think this should be outside the try/except clause.  If it fails, the error
> should be surfaced.  Unlike the other commands, if it fails, you could wind up
> with a bad state in your checkout.

Done.

[szager1, 2013-03-18 23:50:06]

Needs a small fix; otherwise lgtm.

https://codereview.chromium.org/12620024/diff/3001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12620024/diff/3001/gclient_scm.py#newcode205
gclient_scm.py:205: cmd4 = ['git', 'config', 'diff.recurseSubmodules', 'true']
This should be 'fetch.recurseSubmodules'

[jam, 2013-03-18 23:52:09]

thanks for the catch

https://codereview.chromium.org/12620024/diff/3001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12620024/diff/3001/gclient_scm.py#newcode205
gclient_scm.py:205: cmd4 = ['git', 'config', 'diff.recurseSubmodules', 'true']
On 2013/03/18 23:50:06, szager1 wrote:
> This should be 'fetch.recurseSubmodules'

Done.

[commit-bot: I haz the power, 2013-03-19 15:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jam@chromium.org/12620024/8001

[commit-bot: I haz the power, 2013-03-19 15:54:34]

Change committed as 189026