Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 12620003: Fix copy/cut from menu when omnibox is focused (Closed)

Created:
7 years, 9 months ago by vasilii
Modified:
7 years, 9 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix copy/cut from menu when omnibox is focused. Regression was introduced in https://codereview.chromium.org/11734015/ BUG=181196 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vasilii
Hi guys, please review the small fix. John, I added you as a reviewer as ...
7 years, 9 months ago (2013-03-08 17:01:32 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-08 18:29:35 UTC) #2
jam
lgtm, thanks
7 years, 9 months ago (2013-03-08 21:11:16 UTC) #3
jam
lgtm, thanks
7 years, 9 months ago (2013-03-08 21:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/12620003/1
7 years, 9 months ago (2013-03-11 08:17:22 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 12:20:10 UTC) #6
Message was sent while issue was closed.
Change committed as 187278

Powered by Google App Engine
This is Rietveld 408576698