Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12617020: Windows: On context lost, GPU process exits. (Closed)

Created:
7 years, 9 months ago by apatrick_chromium
Modified:
7 years, 8 months ago
CC:
chromium-reviews, apatrick_chromium, Zhenyao Mo
Visibility:
Public.

Description

Windows: On context lost, GPU process exits. Some drivers cannot recover from device lost. IDirect3DDevice9::ResetEx returns an access denied error after a GPU hang. Although this results in a fallback to software, exiting the GPU process allows a newly launched GPU process to reinitialize D3D and GPU accelerated features continue to work. I have observed this with an AMD driver but suspect there are issues with Intel from crash reports. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191705

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M gpu/command_buffer/service/feature_info.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
apatrick_chromium
7 years, 9 months ago (2013-03-26 22:56:31 UTC) #1
Ken Russell (switch to Gerrit)
+zmo lgtm https://codereview.chromium.org/12617020/diff/5001/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/12617020/diff/5001/gpu/command_buffer/service/feature_info.cc#newcode709 gpu/command_buffer/service/feature_info.cc:709: workarounds_.exit_on_context_lost = true; It would be much ...
7 years, 9 months ago (2013-03-27 02:04:11 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/12617020/diff/5001/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/12617020/diff/5001/gpu/command_buffer/service/feature_info.cc#newcode709 gpu/command_buffer/service/feature_info.cc:709: workarounds_.exit_on_context_lost = true; On 2013/03/27 02:04:11, kbr wrote: > ...
7 years, 9 months ago (2013-03-27 02:53:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/12617020/21001
7 years, 8 months ago (2013-04-01 20:06:58 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-01 23:52:30 UTC) #5
Message was sent while issue was closed.
Change committed as 191705

Powered by Google App Engine
This is Rietveld 408576698